linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Jones <cretin@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: Dominik Brodowski <linux@brodo.de>
Subject: [2.6.0-test1] yenta_socket.c:yenta_get_status returns bad value compared to 2.4
Date: 26 Jul 2003 19:31:59 +0100	[thread overview]
Message-ID: <1059244318.3400.17.camel@localhost> (raw)

Dear all,

It seems the the change from 2.4 to 2.6 made the state read from 
yenta_get_status change it's return value. It reads it from hardware.

The change in value has an effect later on which causes CB_CBCARD not to
be set, and thus SOCKET_CARDBUS not being set, this memory reads are
from the wrong ioport, locking up the machine.

Hardware:
00:0a.0 CardBus bridge: O2 Micro, Inc. OZ6912 Cardbus Controller
with a Netgear wireless card for testing.

see http://www.ussg.iu.edu/hypermail/linux/kernel/0307.3/0166.html 
for more info.

I added 

printk(KERN_DEBUG "yenta_get_status: status=%04x\n",state);

after the call 
u32 state = cb_readl(socket, CB_SOCKET_STATE);
in 
static int yenta_get_status(struct pcmcia_socket *sock, unsigned int
*value)
in drivers/pcmcia/yenta_socket.c

in both 2.4.21 and 2.6.0-test1

2.6.0-test1 gives: 30000411
2.4.21 gives:      30000419

I wonder why the values are different, and yet fairly close. It is
enough to give hard lockups ( I debugged this one with printk's and
commenting out code )

I have added 

state |= CB_CBCARD;

to the 2.6 kernel and that stops lockups, but I haven't yet tried
forcing the complete value.

What should I do, who should I contact, please advise. ( I am not a
kernel developer )

Stefan


             reply	other threads:[~2003-07-26 18:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-26 18:31 Stefan Jones [this message]
2003-07-26 19:17 ` [2.6.0-test1] yenta_socket.c:yenta_get_status returns bad value compared to 2.4 OSDL
2003-07-27  9:46 ` Stefan Jones
2003-08-02 17:08 ` Russell King
2003-08-03 11:07   ` Stefan Jones
2003-08-03 12:50     ` Russell King
2003-08-03 13:34       ` Stefan Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1059244318.3400.17.camel@localhost \
    --to=cretin@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).