From: Tugrul Galatali <tugrul@galatali.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Remove what looks like a redundant ffb_options in ffb_drv.c
Date: 27 Jul 2003 18:04:10 -0400 [thread overview]
Message-ID: <1059343449.720.12.camel@duality.galatali.com> (raw)
Decided to try building stock 2.6.0-test2 on an Ultra 60 sitting here,
and ran into a redefinition of ffb_options between ffb_drv.c and
drm_drv.h. The one in ffb_drv.c looks redundant to me, and after
removing it I was able to successfully compile and boot the resulting
kernel.
Tugrul Galatali
diff -u linux-2.6.0-test2/drivers/char/drm/ffb_drv.c.orig linux-2.6.0-test2/drivers/char/drm/ffb_drv.c
--- linux-2.6.0-test2/drivers/char/drm/ffb_drv.c.orig 2003-07-27 17:08:18.000000000 -0400
+++ linux-2.6.0-test2/drivers/char/drm/ffb_drv.c 2003-07-27 17:06:58.000000000 -0400
@@ -372,25 +372,6 @@
return ret;
}
-#ifndef MODULE
-/* DRM(options) is called by the kernel to parse command-line options
- * passed via the boot-loader (e.g., LILO). It calls the insmod option
- * routine, drm_parse_drm.
- */
-
-/* JH- We have to hand expand the string ourselves because of the cpp. If
- * anyone can think of a way that we can fit into the __setup macro without
- * changing it, then please send the solution my way.
- */
-static int __init ffb_options(char *str)
-{
- DRM(parse_options)(str);
- return 1;
-}
-
-__setup(DRIVER_NAME "=", ffb_options);
-#endif
-
#include "drm_fops.h"
#include "drm_init.h"
#include "drm_ioctl.h"
reply other threads:[~2003-07-27 23:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059343449.720.12.camel@duality.galatali.com \
--to=tugrul@galatali.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).