archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove what looks like a redundant ffb_options in ffb_drv.c
@ 2003-07-27 22:04 Tugrul Galatali
  0 siblings, 0 replies; only message in thread
From: Tugrul Galatali @ 2003-07-27 22:04 UTC (permalink / raw)
  To: linux-kernel

	Decided to try building stock 2.6.0-test2 on an Ultra 60 sitting here,
and ran into a redefinition of ffb_options between ffb_drv.c and
drm_drv.h. The one in ffb_drv.c looks redundant to me, and after
removing it I was able to successfully compile and boot the resulting

	Tugrul Galatali

diff -u linux-2.6.0-test2/drivers/char/drm/ffb_drv.c.orig linux-2.6.0-test2/drivers/char/drm/ffb_drv.c
--- linux-2.6.0-test2/drivers/char/drm/ffb_drv.c.orig   2003-07-27 17:08:18.000000000 -0400
+++ linux-2.6.0-test2/drivers/char/drm/ffb_drv.c        2003-07-27 17:06:58.000000000 -0400
@@ -372,25 +372,6 @@
        return ret;
-#ifndef MODULE
-/* DRM(options) is called by the kernel to parse command-line options
- * passed via the boot-loader (e.g., LILO).  It calls the insmod option
- * routine, drm_parse_drm.
- */
-/* JH- We have to hand expand the string ourselves because of the cpp.  If
- * anyone can think of a way that we can fit into the __setup macro without
- * changing it, then please send the solution my way.
- */
-static int __init ffb_options(char *str)
-       DRM(parse_options)(str);
-       return 1;
-__setup(DRIVER_NAME "=", ffb_options);
 #include "drm_fops.h"
 #include "drm_init.h"
 #include "drm_ioctl.h"

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-07-27 23:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-27 22:04 [PATCH] Remove what looks like a redundant ffb_options in ffb_drv.c Tugrul Galatali

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).