archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <>
To: Lou Langholtz <>
Cc: Linux Kernel Mailing List <>
Subject: Re: PATCH: fix 2 byte data leak due to padding
Date: 28 Jul 2003 12:32:50 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Llu, 2003-07-28 at 04:49, Lou Langholtz wrote:
> >+	memset(&tmp, 0, sizeof(struct __old_kernel_stat));
> >
> Wouldn't it be more clear (better) to use sizeof(tmp) here rather than 
> sizeof(struct _old_kernel_stat)?

sizeof(variable) can be suprising some times so I always use sizeof(type) out
of habit. (Think sizeof(x) when X later becomes a pointer)

  reply	other threads:[~2003-07-28 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-27 20:19 Alan Cox
2003-07-28  3:49 ` Lou Langholtz
2003-07-28 11:32   ` Alan Cox [this message]
2003-07-28 11:44     ` Wichert Akkerman
2003-07-28 19:54     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: PATCH: fix 2 byte data leak due to padding' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).