From: Christophe Saout <christophe@saout.de>
To: Joe Thornber <thornber@sistina.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@zip.com.au>,
Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/6] dm: decimal device num sscanf
Date: 31 Jul 2003 18:13:51 +0200 [thread overview]
Message-ID: <1059668031.14800.9.camel@chtephan.cs.pocnet.net> (raw)
In-Reply-To: <20030731151326.GZ394@fib011235813.fsnet.co.uk>
Am Do, 2003-07-31 um 17.13 schrieb Joe Thornber:
> On Thu, Jul 31, 2003 at 04:04:30PM +0100, Christoph Hellwig wrote:
> > On Thu, Jul 31, 2003 at 11:49:53AM +0100, Joe Thornber wrote:
> > > The 2.4 version of Device-Mapper scans for device-numbers in decimal
> > > instead of hex (in dm_get_device()). Update 2.6 so both versions use
> > > the same behavior. [Kevin Corry]
> >
> > This code should just go away completly. There's no excuse for parsing
> > a dev_t in new code instead of a pathname.
>
> It's in there to match the output from 'dmsetup table'. I'm not sure
> anyone uses it, but I'd still like to keep it so that 2.4 and 2.6 stay
> in sync.
The output from dmsetup table looks different in 2.6 anyway (at least on
my system?), something like: 0 12582912 linear hda7 384
When you have a target that uses another device-mapper device it says
something like dm-5. dmsetup load doesn't like that one.
(BTW: Before 2.5.69 it looked like ide0(3, 7) or something, I don't
remember exactly. My lilo-devmapper patch tries to parse all three
formats, and also fails on things like dm-5...)
--
Christophe Saout <christophe@saout.de>
Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
next prev parent reply other threads:[~2003-07-31 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 10:45 2.6.0-test2 device mapper patchset Joe Thornber
2003-07-31 10:48 ` [Patch 1/6] dm: don't use MODULE_PARM Joe Thornber
2003-07-31 10:49 ` [Patch 2/6] dm: remove blk.h include Joe Thornber
2003-07-31 10:49 ` [Patch 3/6] dm: decimal device num sscanf Joe Thornber
2003-07-31 15:04 ` Christoph Hellwig
2003-07-31 15:13 ` Joe Thornber
2003-07-31 15:20 ` Christoph Hellwig
2003-07-31 15:24 ` Joe Thornber
2003-07-31 16:14 ` Christoph Hellwig
2003-07-31 16:27 ` Joe Thornber
2003-08-02 16:54 ` Christoph Hellwig
2003-07-31 16:13 ` Christophe Saout [this message]
2003-07-31 10:50 ` [Patch 4/6] dm: 64 bit ioctl fixes Joe Thornber
2003-07-31 10:51 ` [Patch 5/6] dm: missing #include Joe Thornber
2003-07-31 10:51 ` [Patch 6/6] dm: use sector_div() Joe Thornber
2003-07-31 10:57 ` [Patch 7/6 (so I can't count)] dm: resume() name clash Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059668031.14800.9.camel@chtephan.cs.pocnet.net \
--to=christophe@saout.de \
--cc=akpm@zip.com.au \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@sistina.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).