From: Marcel Holtmann <marcel@holtmann.org>
To: Manuel Estrada Sainz <ranty@debian.org>
Cc: "Barry K. Nathan" <barryn@pobox.com>, Alan Cox <alan@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.22-pre10-ac1
Date: 02 Aug 2003 11:57:31 +0200 [thread overview]
Message-ID: <1059818258.22190.43.camel@pegasus> (raw)
In-Reply-To: <20030802094153.GA4901@ranty.pantax.net>
Hi Manuel,
> > > > ccache gcc -D__KERNEL__ -I/home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/include -Wall -Wstrict-prototypes -Wno-trigraphs -Os -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=firmware_class -DEXPORT_SYMTAB -c firmware_class.c
> > > > firmware_class.c: In function `call_helper':
> > > > firmware_class.c:78: error: `hotplug_path' undeclared (first use in this function)
> > > > firmware_class.c:78: error: (Each undeclared identifier is reported only once
> > > > firmware_class.c:78: error: for each function it appears in.)
> > > > make[1]: *** [firmware_class.o] Error 1
> > > > make[1]: Leaving directory `/home/barryn/lsx/kernels/2.4/build/linux-2.4.22-pre10-ac1/lib'
> > > > make: *** [_mod_lib] Error 2
> > > [snip]
> > > > # CONFIG_HOTPLUG is not set
> > >
> > > CONFIG_HOTPLUG needs to be enabled, attached patch to make it explicit:
> >
> > your patch didn't fix the problem, because it will be the same if some
> > internal driver needs request_firmware() and CONFIG_HOTPLUG is not set.
> > The call_helper() funtcion needs to be put into #idef's.
>
> request_firmware() needs hotplug to do anything useful, without
> hotplug it doesn't make any sense. It is useless.
not quite true. If hotplug is not enabled it tells the driver that the
firmware can't be loaded. It is the same if hotplug_path is zero, or you
don't have the firmware.agent script, or your firmware is not present on
the filesystem or any other worse happens. But to handle these problems
is up to the driver.
You will have the same problem, if you disable the /proc filesystem or
don't mount it. You can't control all things a user is doing from inside
the kernel.
Regards
Marcel
next prev parent reply other threads:[~2003-08-02 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-01 22:16 Linux 2.4.22-pre10-ac1 Alan Cox
2003-08-02 4:09 ` Barry K. Nathan
2003-08-02 6:37 ` Manuel Estrada Sainz
2003-08-02 9:23 ` Marcel Holtmann
2003-08-02 9:41 ` Manuel Estrada Sainz
2003-08-02 9:57 ` Marcel Holtmann [this message]
2003-08-02 12:29 ` Alan Cox
2003-08-02 13:42 ` Marcel Holtmann
2003-08-10 22:34 ` Manuel Estrada Sainz
2003-08-03 10:57 ` [patch] 2.4.22-pre10-ac1: fix tp600.c compile warning Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059818258.22190.43.camel@pegasus \
--to=marcel@holtmann.org \
--cc=alan@redhat.com \
--cc=barryn@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).