From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Javier Achirica <achirica@telefonica.net>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] airo driver: fix races, oops, etc..
Date: 05 Aug 2003 11:48:12 +0200 [thread overview]
Message-ID: <1060076891.615.57.camel@gaston> (raw)
In-Reply-To: <Pine.SOL.4.30.0308051048130.2746-100000@tudela.mad.ttd.net>
On Tue, 2003-08-05 at 10:53, Javier Achirica wrote:
> I've integrated this patch in my code. I've done a major change: Instead
> of using schedule_delayed_work(), I create a new workqueue and use
> queue_work() on that queue. As all tasks sleep in the same lock, I can
> queue them there and make them sleep instead of requeueing them.
>
> I haven't sent them to Jeff yet, as I want to do more testing. If you want
> to help testing them, please tell me.
Well... creating a work queue means you create one thread per CPU, that
sucks a bit don't think ? Maybe using a single thread for the driver
with your own queuing primitives...
Ben.
next prev parent reply other threads:[~2003-08-05 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-29 13:02 [PATCH] airo driver: fix races, oops, etc Benjamin Herrenschmidt
2003-08-05 8:53 ` Javier Achirica
2003-08-05 9:48 ` Benjamin Herrenschmidt [this message]
2003-08-05 10:18 ` Javier Achirica
2003-08-07 7:49 ` Javier Achirica
2003-08-07 14:51 ` Jeff Garzik
2003-08-08 8:54 ` Javier Achirica
2003-07-29 16:26 Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060076891.615.57.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=achirica@telefonica.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).