From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbWAQG4V (ORCPT ); Tue, 17 Jan 2006 01:56:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbWAQG4V (ORCPT ); Tue, 17 Jan 2006 01:56:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:20135 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1751227AbWAQG4U (ORCPT ); Tue, 17 Jan 2006 01:56:20 -0500 From: NeilBrown To: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 17 Jan 2006 17:56:14 +1100 Message-Id: <1060117065614.27831@suse.de> X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D Subject: [PATCH 001 of 5] md: Split disks array out of raid5 conf structure so it is easier to grow. References: <20060117174531.27739.patches@notabene> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Previously the array of disk information was included in the raid5 'conf' structure which was allocated to an appropriate size. This makes it awkward to change the size of that array. So we split it off into a separate kmalloced array which will require a little extra indexing, but is much easier to grow. Signed-off-by: Neil Brown ### Diffstat output ./drivers/md/raid5.c | 10 +++++++--- ./drivers/md/raid6main.c | 11 ++++++++--- ./include/linux/raid/raid5.h | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff ./drivers/md/raid5.c~current~ ./drivers/md/raid5.c --- ./drivers/md/raid5.c~current~ 2006-01-17 17:33:05.000000000 +1100 +++ ./drivers/md/raid5.c 2006-01-17 17:33:09.000000000 +1100 @@ -1821,11 +1821,13 @@ static int run(mddev_t *mddev) return -EIO; } - mddev->private = kzalloc(sizeof (raid5_conf_t) - + mddev->raid_disks * sizeof(struct disk_info), - GFP_KERNEL); + mddev->private = kzalloc(sizeof (raid5_conf_t), GFP_KERNEL); if ((conf = mddev->private) == NULL) goto abort; + conf->disks = kzalloc(mddev->raid_disks * sizeof(struct disk_info), + GFP_KERNEL); + if (!conf->disks) + goto abort; conf->mddev = mddev; @@ -1965,6 +1967,7 @@ static int run(mddev_t *mddev) abort: if (conf) { print_raid5_conf(conf); + kfree(conf->disks); kfree(conf->stripe_hashtbl); kfree(conf); } @@ -1985,6 +1988,7 @@ static int stop(mddev_t *mddev) kfree(conf->stripe_hashtbl); blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/ sysfs_remove_group(&mddev->kobj, &raid5_attrs_group); + kfree(conf->disks); kfree(conf); mddev->private = NULL; return 0; diff ./drivers/md/raid6main.c~current~ ./drivers/md/raid6main.c --- ./drivers/md/raid6main.c~current~ 2006-01-17 17:33:05.000000000 +1100 +++ ./drivers/md/raid6main.c 2006-01-17 17:33:09.000000000 +1100 @@ -1925,11 +1925,14 @@ static int run(mddev_t *mddev) return -EIO; } - mddev->private = kzalloc(sizeof (raid6_conf_t) - + mddev->raid_disks * sizeof(struct disk_info), - GFP_KERNEL); + mddev->private = kzalloc(sizeof (raid6_conf_t), GFP_KERNEL); if ((conf = mddev->private) == NULL) goto abort; + conf->disks = kzalloc(mddev->raid_disks * sizeof(struct disk_info), + GFP_KERNEL); + if (!conf->disks) + goto abort; + conf->mddev = mddev; if ((conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL)) == NULL) @@ -2077,6 +2080,7 @@ abort: print_raid6_conf(conf); safe_put_page(conf->spare_page); kfree(conf->stripe_hashtbl); + kfree(conf->disks); kfree(conf); } mddev->private = NULL; @@ -2095,6 +2099,7 @@ static int stop (mddev_t *mddev) shrink_stripes(conf); kfree(conf->stripe_hashtbl); blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/ + kfree(conf->disks); kfree(conf); mddev->private = NULL; return 0; diff ./include/linux/raid/raid5.h~current~ ./include/linux/raid/raid5.h --- ./include/linux/raid/raid5.h~current~ 2006-01-17 17:33:05.000000000 +1100 +++ ./include/linux/raid/raid5.h 2006-01-17 17:33:09.000000000 +1100 @@ -240,7 +240,7 @@ struct raid5_private_data { * waiting for 25% to be free */ spinlock_t device_lock; - struct disk_info disks[0]; + struct disk_info *disks; }; typedef struct raid5_private_data raid5_conf_t;