linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Matt Mackall <mpm@selenic.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	James Morris <jmorris@intercode.com.au>,
	"David S. Miller" <davem@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cryptoapi: Fix sleeping
Date: Thu, 14 Aug 2003 09:29:20 -0700	[thread overview]
Message-ID: <1060878560.4709.474.camel@lettuce> (raw)
In-Reply-To: <20030814015820.GH325@waste.org>

On Wed, 2003-08-13 at 18:58, Matt Mackall wrote:

> This is part of cryptoapi and given the large chunks of work you could
> potentially hand to it, it's probably a good idea for it to work this
> way. You hand it a long list of sg segments, it does the transform and
> reschedules if it thinks it's safe. But its test of when it was safe
> was not complete.

Right.  My concern is that you said sometimes it is called when
preemption is disabled.

I assume because it is accessing per-processor data.

It is illegal to reschedule -- regardless of kernel preemption -- while
in the middle of a critical section accessing per-processor data.

	Robert Love



  reply	other threads:[~2003-08-14 16:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-13 23:39 [PATCH] cryptoapi: Fix sleeping Matt Mackall
2003-08-14  0:21 ` Jeff Garzik
2003-08-14  0:34   ` Robert Love
2003-08-14  1:58     ` Matt Mackall
2003-08-14 16:29       ` Robert Love [this message]
2003-08-14 16:33         ` Matt Mackall
2003-08-14  0:44   ` Andrew Morton
2003-08-14  2:03     ` Matt Mackall
2003-08-14  7:15       ` Matt Mackall
2003-08-14 17:08         ` James Morris
2003-08-14 20:18           ` Matt Mackall
2003-08-15  3:39             ` James Morris
2003-08-15  3:50               ` Matt Mackall
2003-08-15  4:07                 ` James Morris
2003-08-14  1:54   ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1060878560.4709.474.camel@lettuce \
    --to=rml@tech9.net \
    --cc=davem@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=jmorris@intercode.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).