From: "Sérgio Monteiro Basto" <sergiomb@netcabo.pt>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: "Brown, Len" <len.brown@intel.com>,
Jeff Garzik <jgarzik@pobox.com>,
Andrew Grover <andrew.grover@intel.com>,
"J.A. Magallon" <jamagallon@able.es>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
acpi-devel@sourceforge.net
Subject: Re: [ACPI] RE: [patch] 2.4.x ACPI updates
Date: 21 Aug 2003 00:06:16 +0100 [thread overview]
Message-ID: <1061420776.1790.18.camel@darkstar.portugal> (raw)
In-Reply-To: <Pine.LNX.4.55L.0308201514140.617@freak.distro.conectiva>
[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]
Hi
So had this compile error :
setup.c: In function `parse_cmdline_early':
setup.c:830: `skip_ioapic_setup' undeclared (first use in this function)
setup.c:830: (Each undeclared identifier is reported only once
setup.c:830: for each function it appears in.)
Since just in arch/i386/kernel/io_apic.c, skip_ioapic_setup is declared
and in arch/i386/kernel/Makefile we have
obj-$(CONFIG_X86_IO_APIC) += io_apic.o
I think this is the correct patch.
thanks
On Wed, 2003-08-20 at 19:15, Marcelo Tosatti wrote:
>
>
> On Tue, 19 Aug 2003, Brown, Len wrote:
>
> > Andy/Jeff/Marcelo,
> >
> > At Jeff's request, I've back ported ACPICA 20030813 from
> > http://linux-acpi.bkbits.net/linux-acpi-2.4 into a new tree for 2.4.22:
> > http://linux-acpi.bkbits.net/linux-acpi-2.4.22
> >
> > I've restored acpitable.[ch], which was deleted too late for this
> > release cycle; and will live on until 2.4.23 -- as well as restored
> > CONFIG_ACPI_HT_ONLY under CONFIG_ACPI; restored the 8-bit characters
> > that got expanded to 16-bits in a previous merge; and deleted some dmesg
> > verbiage that Jeff didn't think was appropriate for the baseline kernel.
> >
> > I exported this a patch and then imported onto a clone of Marcelo's
> > tree, so it appears as a single cset where the changes that got un-done
> > never happened. I've done some sanity tests on it, and will test it
> > some more tomorrow. Take a look at it and let me know if I missed
> > anything. When Andy is happy with it I'll leave it to him to re-issue a
> > pull request from Marcelo.
>
> Cool!!
>
> Ill try to take a look at the patch now (having serious conectivity issues
> :()
>
--
SérgioMB
email: sergiomb@netcabo.pt
Who gives me one shell, give me everything.
[-- Attachment #2: fixcompile.diff --]
[-- Type: text/plain, Size: 628 bytes --]
--- linux-2.4.22-rc2.orig/arch/i386/kernel/setup.c Wed Aug 20 23:52:45 2003
+++ linux-2.4.22-rc2/arch/i386/kernel/setup.c Wed Aug 20 23:54:36 2003
@@ -824,11 +824,12 @@
acpi_ht = 1;
if (!acpi_force) acpi_disabled = 1;
}
-
- /* disable IO-APIC */
- else if (!memcmp(from, "noapic", 6)) {
- skip_ioapic_setup = 1;
- }
+#ifdef CONFIG_X86_IO_APIC
+ /* disable IO-APIC */
+ else if (!memcmp(from, "noapic", 6)) {
+ skip_ioapic_setup = 1;
+ }
+#endif
#endif
/*
* highmem=size forces highmem to be exactly 'size' bytes.
next prev parent reply other threads:[~2003-08-20 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-20 0:04 [patch] 2.4.x ACPI updates Brown, Len
2003-08-20 18:15 ` Marcelo Tosatti
2003-08-20 23:06 ` Sérgio Monteiro Basto [this message]
2003-08-20 23:55 [ACPI] " Brown, Len
2003-08-23 21:05 Brown, Len
2003-08-23 21:30 ` Marcelo Tosatti
2003-08-23 22:33 ` [ACPI] " Karol Kozimor
2003-09-02 14:37 ` Pavel Machek
2003-09-08 13:29 ` Karol Kozimor
2003-09-09 7:32 ` Karol Kozimor
2003-08-24 10:36 ` Eric Valette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061420776.1790.18.camel@darkstar.portugal \
--to=sergiomb@netcabo.pt \
--cc=acpi-devel@sourceforge.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrew.grover@intel.com \
--cc=jamagallon@able.es \
--cc=jgarzik@pobox.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).