* [PATCH] 2.6.0-test4 PowerMac IDE breakage
@ 2003-08-23 12:21 Mikael Pettersson
2003-08-23 14:14 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2003-08-23 12:21 UTC (permalink / raw)
To: benh; +Cc: linux-kernel, linuxppc-devel
PowerMac's IDE driver got broken in 2.6.0-test4:
ppc-unknown-linux-gcc -Wp,-MD,drivers/ide/ppc/.pmac.o.d -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -Iarch/ppc -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -D__KERNEL__ -Iinclude -Iarch/ppc -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -Iarch/ppc -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -fomit-frame-pointer -nostdinc -iwithprefix include -Idrivers/ide -DKBUILD_BASENAME=pmac -DKBUILD_MODNAME=pmac -c -o drivers/ide/ppc/pmac.o drivers/ide/ppc/pmac.c
drivers/ide/ppc/pmac.c: In function `pmac_ide_build_sglist':
drivers/ide/ppc/pmac.c:945: warning: passing arg 1 of `blk_rq_map_sg' from incompatible pointer type
Fixed by the patch below.
/Mikael
diff -ruN linux-2.6.0-test4/drivers/ide/ppc/pmac.c linux-2.6.0-test4.ide-pmac-fix/drivers/ide/ppc/pmac.c
--- linux-2.6.0-test4/drivers/ide/ppc/pmac.c 2003-08-23 12:46:26.000000000 +0200
+++ linux-2.6.0-test4.ide-pmac-fix/drivers/ide/ppc/pmac.c 2003-08-23 13:04:32.000000000 +0200
@@ -942,7 +942,7 @@
if (hwif->sg_dma_active)
BUG();
- nents = blk_rq_map_sg(&drive->queue, rq, sg);
+ nents = blk_rq_map_sg(drive->queue, rq, sg);
if (rq_data_dir(rq) == READ)
pmif->sg_dma_direction = PCI_DMA_FROMDEVICE;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.0-test4 PowerMac IDE breakage
2003-08-23 12:21 [PATCH] 2.6.0-test4 PowerMac IDE breakage Mikael Pettersson
@ 2003-08-23 14:14 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2003-08-23 14:14 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-kernel mailing list, linuxppc-devel
On Sat, 2003-08-23 at 14:21, Mikael Pettersson wrote:
> PowerMac's IDE driver got broken in 2.6.0-test4:
>
> ppc-unknown-linux-gcc -Wp,-MD,drivers/ide/ppc/.pmac.o.d -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -Iarch/ppc -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -D__KERNEL__ -Iinclude -Iarch/ppc -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -Iarch/ppc -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -fomit-frame-pointer -nostdinc -iwithprefix include -Idrivers/ide -DKBUILD_BASENAME=pmac -DKBUILD_MODNAME=pmac -c -o drivers/ide/ppc/pmac.o drivers/ide/ppc/pmac.c
> drivers/ide/ppc/pmac.c: In function `pmac_ide_build_sglist':
> drivers/ide/ppc/pmac.c:945: warning: passing arg 1 of `blk_rq_map_sg' from incompatible pointer type
>
> Fixed by the patch below.
Patch for this (and others) inluding other updates to the driver
on it's way to Linus...
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-23 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-23 12:21 [PATCH] 2.6.0-test4 PowerMac IDE breakage Mikael Pettersson
2003-08-23 14:14 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).