archive mirror
 help / color / mirror / Atom feed
* [PATCH] 2.6.0-test4 (#7) - correct name field breakage in zoran driver
@ 2003-08-24 10:52 Ronald Bultje
  0 siblings, 0 replies; only message in thread
From: Ronald Bultje @ 2003-08-24 10:52 UTC (permalink / raw)
  To: Andrew Morton; +Cc: LKML, Linus Torvalds

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]


I suddenly noticed that 2.6.0-test4 seems to have removed the struct
device->name field, apparently for memory consumption reasons. Linus
changed this to pci_name((zr)->pci_dev) in my driver, and that's almost
correct, except that it is the PCI device ID, and I'm not supposed to
touch it. Also, since it's only 4 bytes, all my device names now show
like 'DC1' (this should be 'DC10plus') and alike.

The attached patch fixes this by going back to the behaviour that we
used in 2.4.x: we use a separate name field in our private driver

I promise I won't send in more patches after this one for today. :).


Ronald Bultje <>

[-- Attachment #2: 20030824_name.diff --]
[-- Type: text/plain, Size: 778 bytes --]

--- linux-2.6.0-test4-old/drivers/media/video/zoran.h	Sun Aug 24 01:42:57 2003
+++ linux-2.6.0-test4/drivers/media/video/zoran.h	Sun Aug 24 12:35:59 2003
@@ -146,7 +146,7 @@
 #define ZORAN_NAME    "ZORAN"	/* name of the device */
-#define ZR_DEVNAME(zr) pci_name((zr)->pci_dev)
+#define ZR_DEVNAME(zr) ((zr)->name)
 #define   BUZ_MAX_WIDTH   (zr->timing->Wa)
 #define   BUZ_MAX_HEIGHT  (zr->timing->Ha)
@@ -403,9 +403,7 @@
 	struct tvnorm *timing;
 	unsigned short id;	/* number of this device */
 	char name[32];		/* name of this device */
 	struct pci_dev *pci_dev;	/* PCI device */
 	unsigned char revision;	/* revision of zr36057 */
 	unsigned int zr36057_adr;	/* bus address of IO mem returned by PCI BIOS */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-08-24 10:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-24 10:52 [PATCH] 2.6.0-test4 (#7) - correct name field breakage in zoran driver Ronald Bultje

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).