linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinay K Nallamothu <vinay-rc@naturesoft.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.0-test4][NET] 3c509.c: remove device.name field
Date: 24 Aug 2003 17:55:40 +0530	[thread overview]
Message-ID: <1061727940.1288.4.camel@lima.royalchallenge.com> (raw)
In-Reply-To: <20030824034735.534b8c68.davem@redhat.com>

Hi Dave,

On Sun, 2003-08-24 at 16:17, David S. Miller wrote:
> On 23 Aug 2003 18:43:29 +0530
> Vinay K Nallamothu <vinay-rc@naturesoft.net> wrote:
> 
> > This patch removes the device name field which is no longer present.
> 
> This doesn't look like the right fix.  You can't just
> delete these lines, you should rather replace them with
> accesses to whatever the MCA device struct name field is.
> 
> 
Pls find the updated patch (hopefully right this time) below:

Thanks
vinay

--- linux-2.6.0-test4/drivers/net/3c509.c	2003-08-23 13:14:30.000000000 +0530
+++ linux-2.6.0-test4-nvk/drivers/net/3c509.c	2003-08-24 17:51:19.000000000 +0530
@@ -629,8 +629,8 @@
 			   el3_mca_adapter_names[mdev->index], slot + 1);
 
 		/* claim the slot */
-		strncpy(device->name, el3_mca_adapter_names[mdev->index],
-				sizeof(device->name));
+		strncpy(mdev->name, el3_mca_adapter_names[mdev->index],
+				sizeof(mdev->name));
 		mca_device_set_claim(mdev, 1);
 
 		if_port = pos4 & 0x03;


  reply	other threads:[~2003-08-24 12:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-23 13:13 [PATCH 2.6.0-test4][NET] 3c509.c: remove device.name field Vinay K Nallamothu
2003-08-24 10:47 ` David S. Miller
2003-08-24 12:25   ` Vinay K Nallamothu [this message]
2003-08-24 12:03     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1061727940.1288.4.camel@lima.royalchallenge.com \
    --to=vinay-rc@naturesoft.net \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).