linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] linux-2.6.0-test4_cyclone-hpet-fix_A0
Date: 04 Sep 2003 10:53:50 -0700	[thread overview]
Message-ID: <1062698030.1315.1544.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <C8C38546F90ABF408A5961FC01FDBF1902C7D23C@fmsmsx405.fm.intel.com>

On Thu, 2003-09-04 at 10:21, Pallipadi, Venkatesh wrote:

> > Can we not we avoid the cut-n-paste coding?
> > 
> > There is also timer_tsc.c:calibrate_tsc_hpet() which is 
> > almost the same as
> > timer_hpet.c:calibrate_tsc().  Seem to me that we could tweak
> > calibrate_tsc_hpet() a bit, unstaticalise 
> > timer_tsc.c:calibrate_tsc() and
> > have two functions rather than four?
> > 
> 
> 
> How about the attached patch (against mm4), that moves all 
> calibrate tsc functions into a common file, avoiding the duplication. 
> This time I could successfully compile cyclone timer too :). However,

Looks better, any reason calibrate_tsc and calibrate_tsc_hpet can't be
unified (it looks like the same basic code just talking to different
hardware)? I was planning on giving that a shot later today.

> I had to do an unrelated one line change in fixmap (last chunk in 
> the patch) to compile for summit.

Is this just an -mm only thing (2.5 has _X86_CYCLONE_TIMER everywhere)?

thanks
-john





  reply	other threads:[~2003-09-04 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-04 17:21 [PATCH] linux-2.6.0-test4_cyclone-hpet-fix_A0 Pallipadi, Venkatesh
2003-09-04 17:53 ` john stultz [this message]
2003-09-04 18:04   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2003-09-04 18:23 Pallipadi, Venkatesh
2003-09-04  4:29 john stultz
2003-09-04  5:59 ` Andrew Morton
2003-09-04  7:14   ` john stultz
2003-09-04 14:48     ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1062698030.1315.1544.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).