From: John Cherry <cherry@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: IA32 - 6 New warnings (gcc 3.2.2)
Date: 26 Sep 2003 14:13:12 -0700 [thread overview]
Message-ID: <1064610791.10304.75.camel@cherrytest.pdx.osdl.net> (raw)
In-Reply-To: <1064608625.10304.52.camel@cherrytest.pdx.osdl.net>
The log for building sis_mm.c shows...
CC drivers/char/drm/sis_mm.o
drivers/char/drm/sis_mm.c:37:25: linux/sisfb.h: No such file or
directory
drivers/char/drm/sis_mm.c: In function `sis_fb_alloc':
drivers/char/drm/sis_mm.c:92: storage size of `req' isn't known
drivers/char/drm/sis_mm.c:98: warning: implicit declaration of function
`sis_malloc'
drivers/char/drm/sis_mm.c:105: warning: implicit declaration of function
`sis_free'
drivers/char/drm/sis_mm.c:92: warning: unused variable `req'
drivers/char/drm/sis_mm.c: In function `sis_fb_free':
drivers/char/drm/sis_mm.c:135: warning: int format, long unsigned int
arg (arg 3)
drivers/char/drm/sis_mm.c:135: warning: int format, long unsigned int
arg (arg 3)
The bug is that linux/sisfb.h should be video/sisfb.h on line 37 of
sis_m.c. The latest linus bk tree and mm kernel seem to have it right.
The snapshot for this build last night must have been between
changesets.
And...the warning makes sense in this context because sis_memreq is
undefined if sisfb.h is not included. :)
John
On Fri, 2003-09-26 at 13:37, John Cherry wrote:
> On Fri, 2003-09-26 at 08:56, Adrian Bunk wrote:
> > On Thu, Sep 25, 2003 at 10:48:35PM -0700, John Cherry wrote:
> > >...
> > > drivers/char/drm/sis_mm.c:92: warning: unused variable `req'
> > >...
> >
> > Looking at the code, this seems to be a bogus warning in the gcc version
> > you are using.
> >
> > cu
> > Adrian
>
> Yes, this warning looks bogus. Hard to understand why this was flagged
> as a warning by gcc 3.2.2...
>
> int sis_fb_alloc( DRM_IOCTL_ARGS )
> {
> drm_sis_mem_t fb;
> --> struct sis_memreq req;
> int retval = 0;
>
> DRM_COPY_FROM_USER_IOCTL(fb, (drm_sis_mem_t *)data, sizeof(fb));
>
> req.size = fb.size;
> --> sis_malloc(&req);
> if (req.offset) {
> /* TODO */
> fb.offset = req.offset;
> fb.free = req.offset;
> if (!add_alloc_set(fb.context, VIDEO_TYPE, fb.free)) {
> DRM_DEBUG("adding to allocation set fails\n");
> sis_free(req.offset);
> retval = DRM_ERR(EINVAL);
> }
> } else {
> fb.offset = 0;
> fb.size = 0;
> fb.free = 0;
> }
> <snip>
>
> John
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2003-09-26 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-26 5:48 IA32 - 6 New warnings (gcc 3.2.2) John Cherry
2003-09-26 15:56 ` Adrian Bunk
2003-09-26 20:37 ` John Cherry
2003-09-26 21:13 ` John Cherry [this message]
2003-09-26 21:49 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064610791.10304.75.camel@cherrytest.pdx.osdl.net \
--to=cherry@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).