From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752361AbdAZLWB (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Jan 2017 06:22:01 -0500
Received: from mail.tpip.net ([92.43.49.48]:60255 "EHLO mail.tpip.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751683AbdAZLWA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Jan 2017 06:22:00 -0500
X-Greylist: delayed 470 seconds by postgrey-1.27 at vger.kernel.org; Thu, 26 Jan 2017 06:21:59 EST
Date: Thu, 26 Jan 2017 12:14:07 +0100 (CET)
From: Andreas Schultz <aschultz@tpip.net>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: netdev <netdev@vger.kernel.org>, Alexey Dobriyan <adobriyan@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        laforge <laforge@gnumonks.org>,
        Johannes Berg <johannes.berg@intel.com>, pablo <pablo@netfilter.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Message-ID: <1065111512.617676.1485429247267.JavaMail.zimbra@tpip.net>
In-Reply-To: <698070a4-e08e-78e5-0214-df69783cce22@users.sourceforge.net>
References: <698070a4-e08e-78e5-0214-df69783cce22@users.sourceforge.net>
Subject: Re: [PATCH 0/5] GTP: Fine-tuning for some function implementations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [153.92.65.89]
X-Mailer: Zimbra 8.7.0_GA_1659 (ZimbraWebClient - GC56 (Win)/8.7.0_GA_1659)
Thread-Topic: Fine-tuning for some function implementations
Thread-Index: FMB8g2AP+CXODqySoDTJj4rNjkMd7A==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Markus,

----- On Jan 26, 2017, at 11:15 AM, SF Markus Elfring elfring@users.sourceforge.net wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 26 Jan 2017 11:10:01 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (5):
>  Use kmalloc_array() in gtp_hashtable_new()
>  Improve another size determination in ipv4_pdp_add()
>  Adjust 12 checks for null pointers
>  Rename jump labels in gtp_encap_enable()
>  Rename jump labels in gtp_hashtable_new()

Looks good to me, for all the above:

Reviewed-by: Andreas Schultz <aschultz@tpip.net>

Andreas

> 
> drivers/net/gtp.c | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)
> 
> --
> 2.11.0