From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbdJSWMf (ORCPT ); Thu, 19 Oct 2017 18:12:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbdJSWMd (ORCPT ); Thu, 19 Oct 2017 18:12:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 16E95BDCE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <97659d0c-6992-3025-0f85-819d23e954cc@infradead.org> References: <97659d0c-6992-3025-0f85-819d23e954cc@infradead.org> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842464774.7923.7951986297563109339.stgit@warthog.procyon.org.uk> To: Randy Dunlap Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Re: [PATCH 02/27] Add a SysRq option to lift kernel lockdown MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10670.1508451150.1@warthog.procyon.org.uk> Date: Thu, 19 Oct 2017 23:12:30 +0100 Message-ID: <10671.1508451150@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 19 Oct 2017 22:12:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap wrote: > > +config ALLOW_LOCKDOWN_LIFT > > + bool > > + help > > + Allow the lockdown on a kernel to be lifted, thereby restoring the > > + ability of userspace to access the kernel image (eg. by SysRq+x under > > how about: on > > > + x86). I'll just get rid of this config option, I think - it doesn't make anything available outside of lock_down.c. > > +#ifdef CONFIG_ALLOW_LOCKDOWN_LIFT_BY_KEY > > is that the same as: CONFIG_ALLOW_LOCKDOWN_LIFT_BY_SYSRQ ? > tested? My test machine doesn't have a physical keyboard attached, but you're right. David