From: David Howells <dhowells@redhat.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: dhowells@redhat.com, James Morris <jmorris@namei.org>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PULL] Smack: Restore the smackfsdef mount option
Date: Tue, 28 May 2019 20:02:15 +0100 [thread overview]
Message-ID: <10710.1559070135@warthog.procyon.org.uk> (raw)
In-Reply-To: <6889f4f9-4ae0-8a92-a2fc-04151ad8ed9f@schaufler-ca.com>
Casey Schaufler <casey@schaufler-ca.com> wrote:
> James, this is a repair for a regression introduced in 5.1.
> It should be pulled for 5.2 and added to 5.1.
>
> The following changes since commit 619ae03e922b65a1a5d4269ceae1e9e13a058d6b:
>
> Smack: Fix kbuild reported build error (2019-04-30 14:13:32 -0700)
>
> are available in the git repository at:
>
> https://github.com/cschaufler/next-smack.git smack-for-5.2-b
>
> for you to fetch changes up to a5765ce797070d046dc53ccceeb0ed304cb918eb:
>
> Smack: Restore the smackfsdef mount option (2019-05-28 10:22:04 -0700)
Can you hold this for the moment, please?
Note that there appears to be another problem by inspection of the code. I
think that smack_sb_eat_lsm_opts() strips the "smack" prefix off of the
options, whereas smack_fs_context_parse_param() does not.
This means that there's no need to do this:
static const struct fs_parameter_spec smack_param_specs[] = {
+ fsparam_string("fsdef", Opt_fsdefault),
fsparam_string("fsdefault", Opt_fsdefault),
fsparam_string("fsfloor", Opt_fsfloor),
fsparam_string("fshat", Opt_fshat),
but that all the option names in that table *do* need prefixing with "smack".
The way you enter the LSM is going to depend on whether
generic_parse_monolithic() is called. You're only going to enter this way if
mount(2) is the syscall of entry and the filesystem doesn't override the
->parse_monolithic() option (none in the upstream kernel).
David
next prev parent reply other threads:[~2019-05-28 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 18:29 [PULL] Smack: Restore the smackfsdef mount option Casey Schaufler
2019-05-28 19:02 ` David Howells [this message]
2019-05-28 19:43 ` Casey Schaufler
2019-05-28 20:18 ` David Howells
2019-05-28 20:37 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10710.1559070135@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).