From: David Woodhouse <dwmw2@infradead.org>
To: Jamie Clark <jclark@metaparadigm.com>
Cc: Andrea Arcangeli <andrea@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.23aa1 ext3 oops
Date: Wed, 17 Dec 2003 11:42:38 +0000 [thread overview]
Message-ID: <1071661358.13152.26.camel@imladris.demon.co.uk> (raw)
In-Reply-To: <3FD7D78A.4080409@metaparadigm.com>
On Thu, 2003-12-11 at 10:33 +0800, Jamie Clark wrote:
> After a quick browse of the assembler output the zeroing would appear to
> be part of the list_del inline, and edi seems to equate to &sb.
Seems reasonable. It does look like something's stomped on sb->s_dirty.
> __mark_inode_dirty() does not appear to take sb_lock before adding to
> the s_dirty list. Could that be the culprit?
I don't think so; it's holding the inode_lock which should be
sufficient. Besides -- in practice all updates to the 4-byte pointer
sb->s_dirty.next are going to be atomic, and there's no reason _ever_
for it to be set to d7ffbc08. It's hard to see how a simple locking
problem is going to cause such a thing.
How repeatable is this? Can you turn on slab poisoning?
--
dwmw2
next prev parent reply other threads:[~2003-12-17 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-04 2:49 2.4.23pre6aa3 scsi oops Jamie Clark
2003-11-04 10:28 ` Andrea Arcangeli
2003-11-04 11:52 ` Jamie Clark
2003-11-04 12:48 ` Andrea Arcangeli
2003-11-27 3:21 ` 2.4.23pre6aa3 - possible ext3 deadlock Jamie Clark
2003-11-27 12:56 ` Jan Kara
2003-12-06 1:05 ` 2.4.23pre6aa3 scsi oops Andrea Arcangeli
2003-12-06 1:39 ` Jamie Clark
2003-12-11 2:33 ` 2.4.23aa1 ext3 oops Jamie Clark
2003-12-16 15:15 ` Marcelo Tosatti
2003-12-16 15:55 ` Jamie Clark
2003-12-17 11:42 ` David Woodhouse [this message]
2003-12-18 6:19 ` Jamie Clark
2003-12-18 6:25 ` David Woodhouse
2003-12-18 7:33 ` Jamie Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1071661358.13152.26.camel@imladris.demon.co.uk \
--to=dwmw2@infradead.org \
--cc=andrea@suse.de \
--cc=jclark@metaparadigm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).