From: Chris Mason <mason@suse.com>
To: Hans Reiser <reiser@namesys.com>
Cc: Peter Zaitsev <peter@mysql.com>, Jens Axboe <axboe@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: True fsync() in Linux (on IDE)
Date: Fri, 19 Mar 2004 08:52:27 -0500 [thread overview]
Message-ID: <1079704347.11057.130.camel@watt.suse.com> (raw)
In-Reply-To: <405AA9D9.40109@namesys.com>
On Fri, 2004-03-19 at 03:05, Hans Reiser wrote:
> Chris Mason wrote:
>
> >On Thu, 2004-03-18 at 16:09, Peter Zaitsev wrote:
> >
> >
> >>On Thu, 2004-03-18 at 13:02, Chris Mason wrote:
> >>
> >>
> >>
> >>>>In the former case cache is surely not flushed.
> >>>>
> >>>>
> >>>>
> >>>Hmmm, is it reiser? For both 2.4 reiserfs and ext3, the flush happens
> >>>when you commit. ext3 always commits on fsync and reiser only commits
> >>>when you've changed metadata.
> >>>
> >>>
> >>Oh. Yes. This is Reiser, I did not think it is FS issue.
> >>I'll know to stay away from ReiserFS now.
> >>
> >>
> >
> >For reiserfs data=ordered should be enough to trigger the needed
> >commits. If not, data=journal. Note that neither fs does barriers for
> >O_SYNC, so we're just not perfect in 2.4.
> >
> >-chris
> >
> You are not listening to Peter. As I understand it from what Peter says
> and your words, your implementation is wrong, and makes fsync
> meaningless. If so, then you need to fix it. fsync should not be
> meaningless even for metadata only journaling. This is a serious bug
> that needs immediate correction, if Peter and I understand it correctly
> from your words.
I am listening to Peter, Jens and I have spent a significant amount of
time on this code. We can go back and spend many more hours testing and
debugging the 2.4 changes, or we can go forward with a very nice
solution in 2.6.
I'm planning on going forward with 2.6
-chris
next prev parent reply other threads:[~2004-03-19 13:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 1:08 True fsync() in Linux (on IDE) Peter Zaitsev
2004-03-18 6:47 ` Jens Axboe
2004-03-18 11:34 ` Matthias Andree
2004-03-18 11:55 ` Jens Axboe
2004-03-18 12:21 ` Matthias Andree
2004-03-18 12:37 ` Jens Axboe
2004-03-18 11:58 ` (no subject) Daniel Czarnecki
2004-03-18 19:44 ` True fsync() in Linux (on IDE) Peter Zaitsev
2004-03-18 19:47 ` Jens Axboe
2004-03-18 20:11 ` Chris Mason
2004-03-18 20:17 ` Peter Zaitsev
2004-03-18 20:33 ` Chris Mason
2004-03-18 20:46 ` Peter Zaitsev
2004-03-18 21:02 ` Chris Mason
2004-03-18 21:09 ` Peter Zaitsev
2004-03-18 21:19 ` Chris Mason
2004-03-19 8:05 ` Hans Reiser
2004-03-19 13:52 ` Chris Mason [this message]
2004-03-19 19:26 ` Peter Zaitsev
2004-03-19 20:23 ` Chris Mason
2004-03-19 20:31 ` Hans Reiser
2004-03-19 20:38 ` Chris Mason
2004-03-19 20:48 ` Hans Reiser
2004-03-19 20:56 ` Chris Mason
2004-03-20 11:04 ` Hans Reiser
2004-03-19 19:36 ` Hans Reiser
2004-03-19 19:57 ` Chris Mason
2004-03-19 20:04 ` Hans Reiser
2004-03-19 20:15 ` Chris Mason
2004-03-19 20:06 ` Peter Zaitsev
2004-03-19 22:03 ` Matthias Andree
2004-03-20 10:20 ` Jamie Lokier
2004-03-20 19:48 ` Peter Zaitsev
2004-03-22 13:08 Heikki Tuuri
2004-03-22 13:23 ` Jens Axboe
2004-03-22 15:17 ` Matthias Andree
2004-03-22 15:35 ` Christoph Hellwig
2004-03-22 19:12 ` Christoffer Hall-Frederiksen
2004-03-22 20:28 ` Matthias Andree
2004-03-22 19:33 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079704347.11057.130.camel@watt.suse.com \
--to=mason@suse.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@mysql.com \
--cc=reiser@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).