From: Jean Delvare <khali@linux-fr.org>
To: Stefan Eletzhofer <stefan.eletzhofer@eletztrick.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add RTC 8564 I2C chip support
Date: Wed, 28 Apr 2004 17:06:13 +0200 [thread overview]
Message-ID: <1083164773.408fc86533f29@imp.gcu.info> (raw)
Hi Stefan,
Just a quick comment about your patch: it's a common habit of the
sensors folks to prefix i2c bus drivers with i2c-, but not chip
drivers. So I would suggest that you name your driver rtc8564, not
i2c-rtc8564.
Also, please keep the lines in drivers/i2c/chips/Makefile in the
alphabetic order. And your header states
"linux/drivers/system3/rtc8564.c" while the driver will be in a
different location. Please correct.
I've not read your code otherwise, I don't know anything about RTCs.
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
next reply other threads:[~2004-04-28 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 15:06 Jean Delvare [this message]
2004-04-28 17:41 ` [PATCH] add RTC 8564 I2C chip support stefan.eletzhofer
-- strict thread matches above, loose matches on Subject: below --
2004-04-28 13:41 stefan.eletzhofer
2004-04-28 13:59 ` stefan.eletzhofer
2004-04-28 15:01 ` Florian Schirmer
2004-04-28 18:26 ` stefan.eletzhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083164773.408fc86533f29@imp.gcu.info \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.eletzhofer@eletztrick.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).