From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FAEC43381 for ; Sun, 17 Feb 2019 12:21:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C048222E0 for ; Sun, 17 Feb 2019 12:21:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="HttOiCVs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728671AbfBQMVZ (ORCPT ); Sun, 17 Feb 2019 07:21:25 -0500 Received: from mout.web.de ([212.227.15.14]:49095 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfBQMVZ (ORCPT ); Sun, 17 Feb 2019 07:21:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1550406055; bh=Hjmz4fiuQ5T8kjSQeyvr89A84AbZO1//ge8xdoWobHk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=HttOiCVsQsHJLapZnByjvRImXIh8CfpomWykOy6xQ80JwXK1viCUewkPzHictCfT4 StxCTfxDvDKt3qym5WAdQWsyS3svgJU//AiarasxtAIxWUxvo5rJqcxcvbzqx/zupl DtFFRb1ffvHDEZijLy/QI+EbpLSFF5n9MszRZWVM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([93.132.167.97]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0McneT-1gdOwo1iAj-00HycB; Sun, 17 Feb 2019 13:20:55 +0100 Subject: Re: [v6] coccinelle: semantic code search for missing put_device() To: Julia Lawall , Wen Yang Cc: Gilles Muller , Nicolas Palix , Michal Marek , Masahiro Yamada , Wen Yang , Cheng Shengyu , kernel-janitors@vger.kernel.org, LKML , Coccinelle References: <8e7ba7c0-b7fe-a1f0-d28b-0c716ecbcfdb@web.de> <1c152067-0135-79d7-1285-4bb9925054c8@web.de> <782fd1c3-80ff-a296-b3a2-351257bb13b3@web.de> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <10836645-5b19-a748-56d7-c0572a76ab4d@web.de> Date: Sun, 17 Feb 2019 13:20:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XbvCgCMiVVL2XYRRWmqnZFQsTRD1W9+g//GesciW7YZ1ipykgsj OvUJu729vIWe9sJpVSSYbSEe1z0XxltkmqQQ1T8qJsFvsgEC/4lXbIGlf9ITAj89jkwmzZx Y1SQJ1PJ+iM5tIDHACIUoZH3V3VoQdn9x5eur9fvhSRTEkNdHmRjcjNQ+/CiIW9fdQ3LOWO DnG2+USieSOcBOA3h3tBQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jEhbihcQYWQ=:xccmEVsWLfZpG99HJpyQPf Xbuj7o4mo0qP8k+02R4zAq1aY+pnd2f59aVb61nQxBEEIERoc/jOsIhrZ+0UcJoPBTSaJNVOk JtlTLW2PvFDk4yHFnZx4U18oCrH3tY+O382ZJldwFQk/mquSQngEDFcL/HyUFGKSHVW3IGOTq IBKthSDNhQzpj6PbbGu9qaUDxtoQ863+liEy1CDC3KokB/jSAscaxlGvrEJ2HP7D67YLtFQWB Y0rwBp56SF0OhtDqk46/Aj5jHp+xTvsoMEJy+3IjgnEbVfLOlKfBVJ3TRE+Op8dntIpnZynLp 2N0XQqjElg5xowfL5DSUU0U8WlzcCObTJevsTf5vRo5WgUFRWoCucBpYhVaTRMJ7HNJ31YSXU zsYMGV1aaC+kifMuST2eGsqp2ij9ZjBJOQZRVoVBG0doVmrvvX8k7+IdnaXKoJ/t9gNEDSwZZ GPm3ikLCyW5lI2ozK5MP2XGxyP+xJg+hRmG5A7Q0dgW1RW6RaGsY9vNBmaIn09DBzUI2jHuBJ 3BFs1OxYMcsmjdi4tqz3hBn1+vwosGChpKN2qBlV3XXhuH20w/JLMNLa/umVwRJRVfDUd3NjQ clzbDehbn+y4Wyo0eDSmHkycxPPpJVhtSpRUStWH7VqfBehLkO4ki8TKcwJRDy4DHBPqF4e+m Be1p7MHmj6lVt8bZ79to4vElIKZk57mpGRQH9+0QgAJ6I7MFuFeDr54ss6rrBGCg2IOU36UYK VnJgxnn1JhRe4dgK9j4/yKFQ3Rvtq4C5P1qUFV/h0fChJnvSnnF6dC7Fkool32F91nhUAiDNW pSg2YNlaC2GwSSPPLJmbR8QMexd/YFsfdXxZV1tBtC/iIYBrPfGZNAtDROMnfCMRbjpadTFuX g1iHVRzcCPsihH+enCR5Sc10vgJ1XIXHtmmoYREkBSlQRyGKjokFS+TTtH77YlaFWmd5023nf cnZbnLXpgdQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> If you would insist on the specification of such an assignment exclusio= n >> for a SmPL ellipsis: >> Can we agree on a correct order? > > I don't get your point. I propose to take another closer look at a bit of SmPL code. > There is no correct order. I have got an other software development view here. > Each order expresses something different. I agree to this information. > The order that is currently in the semantic patch is the one > that is more likely in practice. Please check once more. =E2=80=A6 +@search exists@ +local idexpression id; +expression x,e,e1; +position p1,p2; =E2=80=A6 +@@ + +id =3D of_find_device_by_node@p1(x) +... when !=3D e =3D id =E2=80=A6 Or: =E2=80=A6 + ... when !=3D id =3D e =E2=80=A6 Which SmPL specification will achieve the desired software behaviour? Regards, Markus