From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752243AbdKHSrm (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 13:47:42 -0500
Received: from mout.kundenserver.de ([212.227.17.13]:64358 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751550AbdKHSrk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 13:47:40 -0500
Date: Wed, 8 Nov 2017 19:46:37 +0100 (CET)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Eric Anholt <eric@anholt.net>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, Ray Jui <rjui@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Harald Freudenberger <freude@linux.vnet.ibm.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
        Scott Branden <sbranden@broadcom.com>, linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Martin Kaiser <martin@kaiser.cx>, Matt Mackall <mpm@selenic.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Mark Rutland <mark.rutland@arm.com>,
        linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Sean Wang <sean.wang@mediatek.com>, devicetree@vger.kernel.org
Message-ID: <1086045224.63286.1510166797078@email.1und1.de>
In-Reply-To: <20171108004449.32730-7-f.fainelli@gmail.com>
References: <20171108004449.32730-1-f.fainelli@gmail.com>
 <20171108004449.32730-7-f.fainelli@gmail.com>
Subject: Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.8.3-Rev36
X-Originating-Client: open-xchange-appsuite
X-Provags-ID: V03:K0:FfHmOupFcpX3kaUExo2wbawt0Sxy2xh2QHH6qRoG97fw6cy1E3E
 aPUbWGVCTkbaKcBF6l6aS+fW+PoLds+34ym3v+YKibG2iDtNuibxiVOngb8mOxZvjNgQPe/
 W5OwzOYmNMlQidaPpPh0fWEFFo2yQYcBg5srmYA2dHHgeSXCqlXvJrlrmI5sg8i4e6Xf2jh
 lUqlDg3OcEMelxmcKh0KQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:i5P6JgPyoZ4=:/7fjqMC3IRxTJTXjUrc+sR
 uvTD6FsZBYNGoBJJHQl8cZTMv6PV+t4IAebrqEWZB62Z+FR4JFfrS6cviewUWVYjuk2YnsofX
 E84QfBsC7K+0Cb0NUArB/iQlDJ0jBdFyulMnnU3vh0bzJ4YCTbdUv34M1DvEUQNdchzqohXUr
 Er3k+R7UtGRNQeiQS3+5R6RGsriesTKHqLdPuLFW3A5eXPU35oNDJp91GVcq7tCliiyuSs0Et
 tFkwbC4W2OSPehkc6wtY0ieFTpVWBQM0v7Xr6z0iLZk2Zu4Yd7b1ncNEbqQnwzENqH41kuX3A
 Xebj/Se3+Sv/DIMr00CHcRxPRHWA8V68XA4cZY3WBhRIpIr3OXTxO0vGDIYwut+aTeR+X4PMO
 rO3TMfMt5vL/TM9v5OKRadaHezV5d5xtr+aaq2JzOk//mvMINKiCJSOkuGTQJiDUDvKzxGPAJ
 jJ7OO+fvveeFlGFcvDmcDAnyUk2TWzd/kYmGDCc1lZSgjpc5GQ83NULPiBsOcMHSyash+UDNh
 lymhli2YEVvEbUsIPGqS2VIH/80D5nv2kWLZuvsnAdRR7lViObPnmHL6z1naGaFbpp0+BtzHv
 qL5AwmgPfbMmlb8UlFyAEIOzL2mM87Zftqx1n+qmlJRHNhUmy4RBUtyI5wR01Et/jglI6fOF/
 kAYrdPNGN047X2EuEuldb+EX4nllvZZxIjXLN4Hq1KNpszbghcLqFgeGp7jl0KMIKKFoGe1G0
 dkp0MbtieueKObgr5UPE+qSdEjWVzOcHWwcBL20T0UDCkajEA+bIb1gqkJ0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Florian,

> Florian Fainelli <f.fainelli@gmail.com> hat am 8. November 2017 um 01:44 geschrieben:
> 
> 
> The interrupt masking done for Northstart Plus and Northstar (BCM5301X)
> is moved from being a function pointer mapped to of_device_id::data into
> a proper part of the hwrng::init callback. While at it, we also make the
> of_data be a proper structure indicating the platform specifics, since
> the day we need to add a second type of platform information, we would
> have to do that anyway.

in the lack of proper documentation for bcm2835 rng, is it possible that we should mask the interrupts for bcm2835 as well?