Re: [PATCH v9 07/12] arm64: dts: qcom: sc7280: Add max98360a codec node for CRD 3.0/3.1

[Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>]

On 4/21/2022 10:41 PM, Matthias Kaehlcke wrote:
Thanks for your time Matthias!!!
> On Thu, Apr 21, 2022 at 08:17:34PM +0530, Srinivasa Rao Mandadapu wrote:
>
>> Subject: arm64: dts: qcom: sc7280: Add max98360a codec node for CRD 3.0/3.1
> This isn´t limited to the CRD 3.x, but applies to all herobrine boards,
> so it should be something like "arm64: dts: qcom: sc7280: herobrine:
> Add max98360a codec".
Okay. Will modify commit message accordingly.
>
>> Add max98360a codec node for audio use case on CRD rev5
>> (aka CRD 3.0/3.1) boards.
> ditto
Okay.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
>> index d58045d..f247403 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
>> @@ -20,6 +20,14 @@
>>   #include "sc7280-chrome-common.dtsi"
>>   
>>   / {
>> +	max98360a: audio-codec-0 {
>> +		compatible = "maxim,max98360a";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&amp_en>;
>> +		sdmode-gpios = <&tlmm 63 GPIO_ACTIVE_HIGH>;
>> +		#sound-dai-cells = <0>;
>> +	};
>> +
> This node should be added before 'pwmleds' (alphabetical order
> within the board-specific top level nodes).
Okay. will sort it accordingly.
>
>>   	chosen {
>>   		stdout-path = "serial0:115200n8";
>>   	};
>> -- 
>> 2.7.4
>>