From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbaB0NHy (ORCPT ); Thu, 27 Feb 2014 08:07:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48398 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbaB0NHx (ORCPT ); Thu, 27 Feb 2014 08:07:53 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20140218203346.GG18768@katana> References: <20140218203346.GG18768@katana> <20140109214954.25590.73057.stgit@warthog.procyon.org.uk> To: Wolfram Sang Cc: dhowells@redhat.com, wolfram@the-dreams.de, khali@linux-fr.org, linux-i2c@vger.kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C Date: Thu, 27 Feb 2014 13:07:24 +0000 Message-ID: <10892.1393506444@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram Sang wrote: > 'flags' are u16 and the whole range is needed -> %04x Done. Note that %02x does not preclude more digits, but I guess it's better to have things line up. > for the address simply %03x should do. Done. > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > %*phD at least? My problem with that is that it increases the length of the output by 50% and there's a hard limit on how much output we may produce. David