From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE64C48BE6 for ; Fri, 11 Jun 2021 14:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3312060E09 for ; Fri, 11 Jun 2021 14:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231690AbhFKOlI (ORCPT ); Fri, 11 Jun 2021 10:41:08 -0400 Received: from mx13.kaspersky-labs.com ([91.103.66.164]:16646 "EHLO mx13.kaspersky-labs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFKOlF (ORCPT ); Fri, 11 Jun 2021 10:41:05 -0400 Received: from relay13.kaspersky-labs.com (unknown [127.0.0.10]) by relay13.kaspersky-labs.com (Postfix) with ESMTP id 5E73C520D93; Fri, 11 Jun 2021 17:39:03 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaspersky.com; s=mail202102; t=1623422343; bh=GaTUgIaJPVHNN6WvN2iTl9AOhOMCKXovhrsWAuiSRBM=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=Q/k9i1sMb+yzup85f4nztUJ82vEn+9kaTf4R+bbyBxUsMRifnrfYvtwdvodD+1huG mm8Qdy9wjWbXte7SVmE9dwkNZ0g6PZgvmMggaziJgeUVZMiLi+cY20a85eDW2iQkNs VuBgX6iSIe9z7YXe0MAh3rMGtWYgEVz8jEBiVs0hNOC0yDVIrLJ4KHPF0P4pEIzk3S 4I7CyIP/AAIlIsGzgBIvyd/UDBi6UOuJlj3sGhJVeyp8C9ipX83RWvw/AKDc4Q4cw/ yhqnzev63IsUNvRDcHJmBbi/ryE3tgHto8ELFU83rv3RKQ6wYdg6DLji5M1QQuFDCH V11KvAgZVQUVw== Received: from mail-hq2.kaspersky.com (unknown [91.103.66.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client CN "mail-hq2.kaspersky.com", Issuer "Kaspersky MailRelays CA G3" (verified OK)) by mailhub13.kaspersky-labs.com (Postfix) with ESMTPS id 989B1520DCD; Fri, 11 Jun 2021 17:39:02 +0300 (MSK) Received: from [10.16.171.77] (10.64.64.121) by hqmailmbx3.avp.ru (10.64.67.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Fri, 11 Jun 2021 17:39:02 +0300 Subject: Re: [PATCH v11 00/18] virtio/vsock: introduce SOCK_SEQPACKET support To: Stefano Garzarella CC: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Andra Paraschiv , Norbert Slusarek , Colin Ian King , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "oxffffaa@gmail.com" References: <20210611110744.3650456-1-arseny.krasnov@kaspersky.com> <59b720a8-154f-ad29-e7a9-b86b69408078@kaspersky.com> <20210611122533.cy4jce4vxhhou5ms@steredhat> From: Arseny Krasnov Message-ID: <10a64ff5-86df-85f3-5cf2-2fa7e8ddc294@kaspersky.com> Date: Fri, 11 Jun 2021 17:39:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210611122533.cy4jce4vxhhou5ms@steredhat> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.64.64.121] X-ClientProxiedBy: hqmailmbx1.avp.ru (10.64.67.241) To hqmailmbx3.avp.ru (10.64.67.243) X-KSE-ServerInfo: hqmailmbx3.avp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 06/11/2021 14:16:22 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 164286 [Jun 11 2021] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: arseny.krasnov@kaspersky.com X-KSE-AntiSpam-Info: LuaCore: 448 448 71fb1b37213ce9a885768d4012c46ac449c77b17 X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;kaspersky.com:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/11/2021 14:19:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 11.06.2021 12:41:00 X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KLMS-Rule-ID: 52 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2021/06/11 12:53:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/06/11 13:21:00 #16710450 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.06.2021 15:25, Stefano Garzarella wrote: > Hi Arseny, > > On Fri, Jun 11, 2021 at 02:17:00PM +0300, Arseny Krasnov wrote: >> On 11.06.2021 14:07, Arseny Krasnov wrote: >>> This patchset implements support of SOCK_SEQPACKET for virtio >>> transport. >>> As SOCK_SEQPACKET guarantees to save record boundaries, so to >>> do it, new bit for field 'flags' was added: SEQ_EOR. This bit is >>> set to 1 in last RW packet of message. >>> Now as packets of one socket are not reordered neither on vsock >>> nor on vhost transport layers, such bit allows to restore original >>> message on receiver's side. If user's buffer is smaller than message >>> length, when all out of size data is dropped. >>> Maximum length of datagram is limited by 'peer_buf_alloc' value. >>> Implementation also supports 'MSG_TRUNC' flags. >>> Tests also implemented. >>> >>> Thanks to stsp2@yandex.ru for encouragements and initial design >>> recommendations. >>> >>> Arseny Krasnov (18): >>> af_vsock: update functions for connectible socket >>> af_vsock: separate wait data loop >>> af_vsock: separate receive data loop >>> af_vsock: implement SEQPACKET receive loop >>> af_vsock: implement send logic for SEQPACKET >>> af_vsock: rest of SEQPACKET support >>> af_vsock: update comments for stream sockets >>> virtio/vsock: set packet's type in virtio_transport_send_pkt_info() >>> virtio/vsock: simplify credit update function API >>> virtio/vsock: defines and constants for SEQPACKET >>> virtio/vsock: dequeue callback for SOCK_SEQPACKET >>> virtio/vsock: add SEQPACKET receive logic >>> virtio/vsock: rest of SOCK_SEQPACKET support >>> virtio/vsock: enable SEQPACKET for transport >>> vhost/vsock: enable SEQPACKET for transport >>> vsock/loopback: enable SEQPACKET for transport >>> vsock_test: add SOCK_SEQPACKET tests >>> virtio/vsock: update trace event for SEQPACKET >>> >>> drivers/vhost/vsock.c | 56 ++- >>> include/linux/virtio_vsock.h | 10 + >>> include/net/af_vsock.h | 8 + >>> .../trace/events/vsock_virtio_transport_common.h | 5 +- >>> include/uapi/linux/virtio_vsock.h | 9 + >>> net/vmw_vsock/af_vsock.c | 464 ++++++++++++------ >>> net/vmw_vsock/virtio_transport.c | 26 ++ >>> net/vmw_vsock/virtio_transport_common.c | 179 +++++++- >>> net/vmw_vsock/vsock_loopback.c | 12 + >>> tools/testing/vsock/util.c | 32 +- >>> tools/testing/vsock/util.h | 3 + >>> tools/testing/vsock/vsock_test.c | 116 ++++++ >>> 12 files changed, 730 insertions(+), 190 deletions(-) >>> >>> v10 -> v11: >>> General changelog: >>> - now data is copied to user's buffer only when >>> whole message is received. >>> - reader is woken up when EOR packet is received. >>> - if read syscall was interrupted by signal or >>> timeout, error is returned(not 0). >>> >>> Per patch changelog: >>> see every patch after '---' line. >> So here is new version for review with updates discussed earlier :) > Thanks, I'll review next week, but I suggest you again to split in two > series, since patchwork (and netdev maintainers) are not happy with a > series of 18 patches. > > If you still prefer to keep them together during development, then > please use the RFC tag. > > Also did you take a look at the FAQ for netdev that I linked last time? > I don't see the net-next tag... I didn't use next tag because two patches from first seven(which was considered to be sent to netdev) - 0004 and 0006 were changed in this patchset(because of last ideas about queueing whole message). So i removed R-b line and now there is no sense to use net-next tag for first patches. When it will be R-b - i'll send it to netdev with such tag and we can continue discussing second part of patches(virtio specific). Thank You > > Thanks, > Stefano > >