From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF710C433E6 for ; Fri, 12 Feb 2021 06:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4A5564E77 for ; Fri, 12 Feb 2021 06:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbhBLGMo (ORCPT ); Fri, 12 Feb 2021 01:12:44 -0500 Received: from mx12.kaspersky-labs.com ([91.103.66.155]:37895 "EHLO mx12.kaspersky-labs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhBLGMi (ORCPT ); Fri, 12 Feb 2021 01:12:38 -0500 Received: from relay12.kaspersky-labs.com (unknown [127.0.0.10]) by relay12.kaspersky-labs.com (Postfix) with ESMTP id C2D9775F92; Fri, 12 Feb 2021 09:11:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaspersky.com; s=mail202102; t=1613110312; bh=9NSNujscdOSzEvjcgS1M0d97z+6xEzosf+gBSkx6LJo=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=U8Ua/p6Vf1+CvXME+1FHovT8tiT3kh9ze/HHo4uRVjULtSZV+lZxr0x5aO9IEE22i zj4RovYKVYeO3jRbGNZiJwhgr52RI5uY9BeIw5XERt8+ItcNa84Tf20Dyiff6MzteG QSwr0J4m6Cv5/aiSexF31V3A1sXSZDiN6mDdnbFM+VbaN1A5zJex5crVrdSFTHFp/x inpljc8TUU5UF3OINAUPptlR/8yvnRPpJNFYOi5RLlBhzXxaOTpotP7F4Lm9AC9yVy pnSevbusOgfeOQtBxHjHaeew8uXj6flEHyjAazxeOP6prHoQ1H4Jhae5SY76pj5Ej8 HR1x99SnWdN2g== Received: from mail-hq2.kaspersky.com (unknown [91.103.66.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client CN "mail-hq2.kaspersky.com", Issuer "Kaspersky MailRelays CA G3" (verified OK)) by mailhub12.kaspersky-labs.com (Postfix) with ESMTPS id D2B2775F8B; Fri, 12 Feb 2021 09:11:51 +0300 (MSK) Received: from [10.16.171.77] (10.64.68.129) by hqmailmbx3.avp.ru (10.64.67.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2044.4; Fri, 12 Feb 2021 09:11:51 +0300 Subject: Re: [RFC PATCH v4 00/17] virtio/vsock: introduce SOCK_SEQPACKET support To: Stefano Garzarella CC: "Michael S. Tsirkin" , Stefan Hajnoczi , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Colin Ian King , Alexander Popov , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stsp2@yandex.ru" , "oxffffaa@gmail.com" References: <20210207151259.803917-1-arseny.krasnov@kaspersky.com> <20210207111954-mutt-send-email-mst@kernel.org> <8bd3789c-8df1-4383-f233-b4b854b30970@kaspersky.com> <20210211145701.qikgx5czosdwx3mm@steredhat> From: Arseny Krasnov Message-ID: <10aa4548-2455-295d-c993-30f25fba15f2@kaspersky.com> Date: Fri, 12 Feb 2021 09:11:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210211145701.qikgx5czosdwx3mm@steredhat> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.64.68.129] X-ClientProxiedBy: hqmailmbx3.avp.ru (10.64.67.243) To hqmailmbx3.avp.ru (10.64.67.243) X-KSE-ServerInfo: hqmailmbx3.avp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.16, Database issued on: 02/06/2021 23:52:08 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 161679 [Feb 06 2021] X-KSE-AntiSpam-Info: LuaCore: 422 422 763e61bea9fcfcd94e075081cb96e065bc0509b4 X-KSE-AntiSpam-Info: Version: 5.9.16.0 X-KSE-AntiSpam-Info: Envelope from: arseny.krasnov@kaspersky.com X-KSE-AntiSpam-Info: {Tracking_content_type, plain} X-KSE-AntiSpam-Info: {Tracking_date, moscow} X-KSE-AntiSpam-Info: {Tracking_c_tr_enc, eight_bit} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/06/2021 23:55:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/6/2021 9:17:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-KLMS-Rule-ID: 52 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2021/02/12 04:28:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/02/12 03:08:00 #16194299 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.02.2021 17:57, Stefano Garzarella wrote: > Hi Arseny, > > On Mon, Feb 08, 2021 at 09:32:59AM +0300, Arseny Krasnov wrote: >> On 07.02.2021 19:20, Michael S. Tsirkin wrote: >>> On Sun, Feb 07, 2021 at 06:12:56PM +0300, Arseny Krasnov wrote: >>>> This patchset impelements support of SOCK_SEQPACKET for virtio >>>> transport. >>>> As SOCK_SEQPACKET guarantees to save record boundaries, so to >>>> do it, two new packet operations were added: first for start of record >>>> and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also, >>>> both operations carries metadata - to maintain boundaries and payload >>>> integrity. Metadata is introduced by adding special header with two >>>> fields - message count and message length: >>>> >>>> struct virtio_vsock_seq_hdr { >>>> __le32 msg_cnt; >>>> __le32 msg_len; >>>> } __attribute__((packed)); >>>> >>>> This header is transmitted as payload of SEQ_BEGIN and SEQ_END >>>> packets(buffer of second virtio descriptor in chain) in the same way as >>>> data transmitted in RW packets. Payload was chosen as buffer for this >>>> header to avoid touching first virtio buffer which carries header of >>>> packet, because someone could check that size of this buffer is equal >>>> to size of packet header. To send record, packet with start marker is >>>> sent first(it's header contains length of record and counter), then >>>> counter is incremented and all data is sent as usual 'RW' packets and >>>> finally SEQ_END is sent(it also carries counter of message, which is >>>> counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is >>>> incremented again. On receiver's side, length of record is known from >>>> packet with start record marker. To check that no packets were dropped >>>> by transport, counters of two sequential SEQ_BEGIN and SEQ_END are >>>> checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by >>>> 1) and length of data between two markers is compared to length in >>>> SEQ_BEGIN header. >>>> Now as packets of one socket are not reordered neither on >>>> vsock nor on vhost transport layers, such markers allows to restore >>>> original record on receiver's side. If user's buffer is smaller that >>>> record length, when all out of size data is dropped. >>>> Maximum length of datagram is not limited as in stream socket, >>>> because same credit logic is used. Difference with stream socket is >>>> that user is not woken up until whole record is received or error >>>> occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags. >>>> Tests also implemented. >>>> >>>> Arseny Krasnov (17): >>>> af_vsock: update functions for connectible socket >>>> af_vsock: separate wait data loop >>>> af_vsock: separate receive data loop >>>> af_vsock: implement SEQPACKET receive loop >>>> af_vsock: separate wait space loop >>>> af_vsock: implement send logic for SEQPACKET >>>> af_vsock: rest of SEQPACKET support >>>> af_vsock: update comments for stream sockets >>>> virtio/vsock: dequeue callback for SOCK_SEQPACKET >>>> virtio/vsock: fetch length for SEQPACKET record >>>> virtio/vsock: add SEQPACKET receive logic >>>> virtio/vsock: rest of SOCK_SEQPACKET support >>>> virtio/vsock: setup SEQPACKET ops for transport >>>> vhost/vsock: setup SEQPACKET ops for transport >>>> vsock_test: add SOCK_SEQPACKET tests >>>> loopback/vsock: setup SEQPACKET ops for transport >>>> virtio/vsock: simplify credit update function API >>>> >>>> drivers/vhost/vsock.c | 8 +- >>>> include/linux/virtio_vsock.h | 15 + >>>> include/net/af_vsock.h | 9 + >>>> include/uapi/linux/virtio_vsock.h | 16 + >>>> net/vmw_vsock/af_vsock.c | 588 +++++++++++++++------- >>>> net/vmw_vsock/virtio_transport.c | 5 + >>>> net/vmw_vsock/virtio_transport_common.c | 316 ++++++++++-- >>>> net/vmw_vsock/vsock_loopback.c | 5 + >>>> tools/testing/vsock/util.c | 32 +- >>>> tools/testing/vsock/util.h | 3 + >>>> tools/testing/vsock/vsock_test.c | 126 +++++ >>>> 11 files changed, 895 insertions(+), 228 deletions(-) >>>> >>>> TODO: >>>> - What to do, when server doesn't support SOCK_SEQPACKET. In current >>>> implementation RST is replied in the same way when listening port >>>> is not found. I think that current RST is enough,because case when >>>> server doesn't support SEQ_PACKET is same when listener missed(e.g. >>>> no listener in both cases). > I think is fine. > >>> - virtio spec patch >> Ok > Yes, please prepare a patch to discuss the VIRTIO spec changes. > > For example for 'virtio_vsock_seq_hdr', I left a comment about 'msg_cnt' > naming that should be better to discuss with virtio guys. Ok, i'll prepare it in v5. So I have to send it both LKML(as one of patches) and virtio mailing lists? (e.g. virtio-comment@lists.oasis-open.org) > > Anyway, I reviewed this series and I left some comments. > I think we are in a good shape :-) Great, thanks for review. I'll consider all review comments in next version. > > Thanks, > Stefano > >