From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viorel Suman <viorel.suman@oss.nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Viorel Suman <viorel.suman@nxp.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Date: Tue, 20 Sep 2022 17:59:43 +0200 [thread overview]
Message-ID: <10bd1f39-3971-90ee-5fe4-c44005cdfcc8@linaro.org> (raw)
In-Reply-To: <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116>
On 19/09/2022 20:06, Viorel Suman wrote:
43
>>> #define IMX_SC_R_SECVIO 44
>>> #define IMX_SC_R_DC_1_VIDEO0 45
>>> #define IMX_SC_R_DC_1_VIDEO1 46
>>> #define IMX_SC_R_DC_1_FRAC0 47
>>> +#define IMX_SC_R_V2X 48
>>> #define IMX_SC_R_DC_1 49
>>> +#define IMX_SC_R_UNUSED14 50
>>> #define IMX_SC_R_DC_1_PLL_0 51
>>> #define IMX_SC_R_DC_1_PLL_1 52
>>> #define IMX_SC_R_SPI_0 53
>>> @@ -151,10 +154,10 @@
>>> #define IMX_SC_R_DMA_1_CH29 137
>>> #define IMX_SC_R_DMA_1_CH30 138
>>> #define IMX_SC_R_DMA_1_CH31 139
>>> -#define IMX_SC_R_UNUSED1 140
>>
>> This one disappears...
>
> Hi Krzysztof,
>
> Right, it was renamed in the subsequent SCFW kit
> versions to IMX_SC_R_V2X_PID0, thus - this patch
> rename it in include/dt-bindings/firmware/imx/rsrc.h
> file in order to have this file and SCFW kit defines
> synchronized.
>
> IMX_SC_R_UNUSED1 is not referenced somehow in kernel,
> thus - no compilation issues if renamed to IMX_SC_R_V2X_PID0,
> IMHO it does not make sense to me to add the related
> backward compatibility define like below:
>
> #define IMX_SC_R_UNUSED1 IMX_SC_R_V2X_PID0
The bindings are used by other people (other Linux kernel forks) and by
other projects (like bootloaders and other operating systems). This is
why once set, we do not change them, with some exceptions.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-09-20 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:22 [PATCH v3] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0 Viorel Suman (OSS)
2022-09-19 16:10 ` Krzysztof Kozlowski
2022-09-19 18:06 ` Viorel Suman
2022-09-20 15:59 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bd1f39-3971-90ee-5fe4-c44005cdfcc8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=viorel.suman@nxp.com \
--cc=viorel.suman@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).