From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD80C43142 for ; Tue, 31 Jul 2018 15:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93DBA20862 for ; Tue, 31 Jul 2018 15:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93DBA20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732404AbeGaRjm (ORCPT ); Tue, 31 Jul 2018 13:39:42 -0400 Received: from foss.arm.com ([217.140.101.70]:56682 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732333AbeGaRjm (ORCPT ); Tue, 31 Jul 2018 13:39:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0CA77A9; Tue, 31 Jul 2018 08:58:44 -0700 (PDT) Received: from [10.4.12.131] (e110467-lin.Emea.Arm.com [10.4.12.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2238D3F5BA; Tue, 31 Jul 2018 08:58:42 -0700 (PDT) Subject: Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask) To: Guenter Roeck Cc: Stefan Agner , Christoph Hellwig , Krzysztof Kozlowski , Ard Biesheuvel , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fugang Duan References: <20180727140448.GA29001@lst.de> <20180728165820.GA5731@roeck-us.net> <45f7fc82-fb9c-e666-4ada-c5338d2c1c96@arm.com> <39fa11ce4b7dd151d98868f375baf818@agner.ch> <0e893142-a5db-d119-6eb3-f849db6b5d04@arm.com> <4ce17098-850f-3bb0-b977-8d7932e74e06@arm.com> <20180731154353.GA29601@roeck-us.net> From: Robin Murphy Message-ID: <10c2ca4d-d587-2705-2802-b6df3dc72fd4@arm.com> Date: Tue, 31 Jul 2018 16:58:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180731154353.GA29601@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/18 16:43, Guenter Roeck wrote: > On Tue, Jul 31, 2018 at 03:09:34PM +0100, Robin Murphy wrote: >>> Please note that sparc images still generate the warning (next-20180731). >> >> Ugh, OK, any ideas what sparc does to create these platform devices that >> isn't of_platform_device_create_pdata() and has somehow grown an implicit >> dependency on of_dma_configure() since 4.12? I'm looking, but nothing jumps >> out... >> > > I suspect it might be of_device_register(), called from > arch/sparc/kernel/of_device_64.c:scan_one_device() > arch/sparc/kernel/of_device_32.c:scan_one_device() Right, that's as far as I got as well, so I'm struggling to see how these things ever got DMA masks set before the of_dma_configure() call moved out of of_platform_device_create_pdata(), or why it wasn't a problem prior to the generic dma_ops rework if they didn't :/ Robin.