Re: [PATCH] lib/lz4: remove the exporting of LZ4HC_setExternalDict

From: Denis Efremov <efremov@linux.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sven Schmidt <4sschmid@informatik.uni-hamburg.de>,
	Arnd Bergmann <arnd@arndb.de>, Bongkyu Kim <bongkyu.kim@lge.com>,
	Rui Salvaterra <rsalvaterra@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Kees Cook <keescook@chromium.org>,
	Tony Luck <tony.luck@intel.com>,
	linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] lib/lz4: remove the exporting of LZ4HC_setExternalDict
Date: Tue, 10 Sep 2019 15:13:16 +0300	[thread overview]
Message-ID: <10d12447-7b67-466e-5ab3-3d28256f0621@linux.com> (raw)
In-Reply-To: <20190708151555.8070-1-efremov@linux.com>

+Cc: Andrew Morton <akpm@linux-foundation.org>,
     Masahiro Yamada <yamada.masahiro@socionext.com>

Hi,

On 7/8/19 6:15 PM, Denis Efremov wrote:
> The function LZ4HC_setExternalDict is declared static and marked
> EXPORT_SYMBOL, which is at best an odd combination. Because the function
> is not used outside of the lib/lz4/lz4hc_compress.c file it is defined in,
> this commit removes the EXPORT_SYMBOL() marking.
> 
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
>  lib/lz4/lz4hc_compress.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
> index 176f03b83e56..1b61d874e337 100644
> --- a/lib/lz4/lz4hc_compress.c
> +++ b/lib/lz4/lz4hc_compress.c
> @@ -663,7 +663,6 @@ static void LZ4HC_setExternalDict(
>  	/* match referencing will resume from there */
>  	ctxPtr->nextToUpdate = ctxPtr->dictLimit;
>  }
> -EXPORT_SYMBOL(LZ4HC_setExternalDict);
>  
>  static int LZ4_compressHC_continue_generic(
>  	LZ4_streamHC_t *LZ4_streamHCPtr,
> 

Andrew, could you please look at this patch and accept it if everybody agrees?
static LZ4HC_setExternalDict will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118

There is also a different fix by Arnd Bergmann with making this function non-static:
https://lkml.org/lkml/2019/9/6/669

But since there is no uses of this EXPORT_SYMBOL in kernel and LZ4HC_setExternalDict
is indeed static in the original library https://github.com/lz4/lz4/blob/dev/lib/lz4hc.c#L1054
we came to the conclusion that it will be better to simply unexport the symbol.

Thanks,
Denis