From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755613AbcHSVLD (ORCPT ); Fri, 19 Aug 2016 17:11:03 -0400 Received: from mout.web.de ([212.227.15.4]:54213 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112AbcHSVLC (ORCPT ); Fri, 19 Aug 2016 17:11:02 -0400 Subject: [PATCH 1/2] mmc-block: Use memdup_user() rather than duplicating its implementation To: linux-mmc@vger.kernel.org, Adrian Hunter , Grant Grundler , Jens Axboe , Jon Hunter , Mike Christie , Shawn Lin , Ulf Hansson References: <566ABCD9.1060404@users.sourceforge.net> <68870228-c6a0-5de9-daee-2522a1303857@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <10db7d07-0cee-041f-8755-de412a12bc81@users.sourceforge.net> Date: Fri, 19 Aug 2016 23:10:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <68870228-c6a0-5de9-daee-2522a1303857@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+uQ76+GiMuS9aPtX/nDdDX9MngxvrHEGBN7PEfJGvrwQWXNTHFR G8Bvil4ezWhsvtfpIsvz+qcVBGsy6yFe+D+CLNl3RAtfb51ByznmRHElAdEmHMGy1e51MJz GGdEs8GpPeoUZqQHRqjfbFLhyZVyEf0IUaBLWoueiMITkbeyoo1MwT2bzOtJ7t425Be+mGk SUPavvrrWEyhs9E2iYnHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:fkRAA/hb7Wc=:kyJKrsHnH3+9ejxHCA2Y95 DOs8GgGbQB2aO1UgkQHXo8drwpNPLfsgBJTYJGd6upM4kEpMerqjtI1R5D3MligZw2yDPkfqn vayaRRfJeceijfZuhreGVHQZi0mSkrM5yxr7/4Yg65jTalcxkzgyi9KSpQ4yDHXUgqwb6mKc9 I2Ff0+440aRCGg0gqfTAecd3rWE5bLswSCLcQem1F9BCYetNIldvgtn/inK8Hxh3WHyDlt5/b ECdB/FlZdxK6BwMRS8oyJ05RQZaF8UH668O9mOnIFY2i6H1O2p4DWbBTON1rjzo57yYTxBIE2 dzGpJkThIrCp4D7k25iM46e+MDGXtpOjxGO9T5siIzb+ubAAAhdmEtRDITGJVlA0UUZ1o0PZh Y428O6EpA3pkUvmrR3ljZD2UNne2vjE6QmrC21xLmEmL+pGsHv0ZujGPQGgYalpcwqvoiGazt IBYwWMNT0wW0hjenkLqTGYlsa3YWFYBtj9LX+Kdxjd6KUX+a730WSoKAu7ZvVzdLLf2v3yDik G1VqBLePnPARKCWLG7hvKHzRQIb4Pb4RTCtYJl6Gzbx7Luyc1il7NxoGhq00jtJHKj9SOtT6b svTEkwRLnW4UmiX4RHQ8Tiwx9JYHb3u5FqzuMj+TG+Jq0ylEaaIoW/YWu3U+7YSayX/LlIm2h 1JcZz1j3DNrfyih3z5U3P7pV9nLVPXhjv1pyHeQfOK2mJBT1oIkaCAYr0YZ45v/180SugLXAU HVjD25gAYkaVkwzzQfS0e/3WyDH7j7gLhUJB5pwWLqR0LZDD9rLho6xgLbTIWPyVQtNQ3o9E5 zvNyUKE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 19 Aug 2016 22:46:38 +0200 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. * Delete the integer variable "err" then because the pointer variable "idata" should be sufficient to handle return values alone in this function. Signed-off-by: Markus Elfring --- drivers/mmc/card/block.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 48a5dd7..6ce9492 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -337,22 +337,21 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( struct mmc_ioc_cmd __user *user) { struct mmc_blk_ioc_data *idata; - int err; idata = kmalloc(sizeof(*idata), GFP_KERNEL); if (!idata) { - err = -ENOMEM; + idata = ERR_PTR(-ENOMEM); goto out; } if (copy_from_user(&idata->ic, user, sizeof(idata->ic))) { - err = -EFAULT; + idata = ERR_PTR(-EFAULT); goto idata_err; } idata->buf_bytes = (u64) idata->ic.blksz * idata->ic.blocks; if (idata->buf_bytes > MMC_IOC_MAX_BYTES) { - err = -EOVERFLOW; + idata = ERR_PTR(-EOVERFLOW); goto idata_err; } @@ -361,26 +360,19 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( return idata; } - idata->buf = kmalloc(idata->buf_bytes, GFP_KERNEL); - if (!idata->buf) { - err = -ENOMEM; + idata->buf = memdup_user((void __user *)(unsigned long) + idata->ic.data_ptr, + idata->buf_bytes); + if (IS_ERR(idata->buf)) { + idata = (void *) idata->buf; goto idata_err; } - - if (copy_from_user(idata->buf, (void __user *)(unsigned long) - idata->ic.data_ptr, idata->buf_bytes)) { - err = -EFAULT; - goto copy_err; - } - return idata; -copy_err: - kfree(idata->buf); idata_err: kfree(idata); out: - return ERR_PTR(err); + return idata; } static int mmc_blk_ioctl_copy_to_user(struct mmc_ioc_cmd __user *ic_ptr, -- 2.9.3