From: David Woodhouse <dwmw2@infradead.org>
To: Andi Kleen <ak@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [discuss] Re: RFC: let x86_64 no longer define X86
Date: Fri, 19 Nov 2004 13:58:00 +0000 [thread overview]
Message-ID: <1100872680.8191.7391.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <20041119120549.GD21483@wotan.suse.de>
On Fri, 2004-11-19 at 13:05 +0100, Andi Kleen wrote:
> I don't know details about the driver, but it's not enabled on x86-64
> because x86-64 doesn't have ISA set.
That looks bogus actually -- I think it should only depend on the
existence of parport_pc style hardware. CONFIG_ISA is definitely a
digression. But still, either way the example is wrong. It shouldn't be
limited to X86 and X86_64.
I still haven't found good examples of cases where X86 is used and we
would want to change that to X86 || X86_64. Could this be one?
config HW_RANDOM
tristate "Intel/AMD/VIA HW Random Number Generator support"
depends on (X86 || IA64) && PCI
...or this?
config FTAPE
tristate "Ftape (QIC-80/Travan) support"
depends on BROKEN_ON_SMP && (ALPHA || X86)
I also see some which already have it:
config NVRAM
tristate "/dev/nvram support"
depends on ATARI || X86 || X86_64 || ARM || GENERIC_NVRAM
config HANGCHECK_TIMER
tristate "Hangcheck timer"
depends on X86_64 || X86
And some which seem to be wrong because they want only X86 not X86_64:
config SONYPI
tristate "Sony Vaio Programmable I/O Control Device support (EXPERIMENTAL)"
depends on EXPERIMENTAL && X86 && PCI && INPUT && !64BIT
config MWAVE
tristate "ACP Modem (Mwave) support"
depends on X86
select SERIAL_8250
Using X86 to include X86_64 is bizarre and inconsistent, and it's
already leading to errors in Kconfig. Let's fix it.
--
dwmw2
next prev parent reply other threads:[~2004-11-19 14:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 0:51 RFC: let x86_64 no longer define X86 Adrian Bunk
2004-11-19 1:14 ` Nick Piggin
2004-11-19 1:19 ` Adrian Bunk
2004-11-19 1:31 ` [discuss] " Paul Menage
2004-11-19 12:28 ` Adrian Bunk
2004-11-19 12:40 ` Andi Kleen
2004-11-19 13:29 ` Adrian Bunk
2004-11-19 8:51 ` Andi Kleen
2004-11-19 10:21 ` Jeff Garzik
2004-11-19 10:34 ` [discuss] " Andi Kleen
2004-11-19 11:28 ` David Woodhouse
2004-11-19 11:55 ` Andi Kleen
2004-11-19 11:50 ` David Woodhouse
2004-11-19 12:05 ` Andi Kleen
2004-11-19 12:12 ` Jeff Garzik
2004-11-19 12:19 ` Andi Kleen
2004-11-19 12:37 ` Jeff Garzik
2004-11-19 12:45 ` Adrian Bunk
2004-11-19 12:55 ` linux-os
2004-11-19 13:04 ` Jeff Garzik
2004-11-19 13:35 ` Raul Miller
2004-11-19 14:11 ` Adrian Bunk
2004-11-19 13:58 ` David Woodhouse [this message]
2004-11-19 12:05 ` Adrian Bunk
2004-11-19 12:09 ` Andi Kleen
2004-11-19 11:18 ` Takashi Iwai
2004-11-19 22:31 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100872680.8191.7391.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=discuss@x86-64.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).