linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.10-rc2-mm2: spinlock problem in arch/i386/kernel/time.c on resume
Date: Fri, 19 Nov 2004 13:14:31 -0800	[thread overview]
Message-ID: <1100898871.5056.10.camel@localhost> (raw)
In-Reply-To: <20041119025357.4b6ca9f7.akpm@osdl.org>

On Fri, 2004-11-19 at 02:53 -0800, Andrew Morton wrote:
> I can't imagine how that could happen.  I wonder if the spinlock debugging
> could be making a mistake.

When I disabled DEBUG_SPINLOCK, it works fine.  Does DEBUG_SPINLOCK have
any side effects?  I would have thought it wouldn't do anything on a UP,
non-PREEMPT system.

There is the comment in arch/i386/kernel/time.c saying that APM needs
get_cmos_time(), which is the site of the second message.  The code is
very simple, so its hard to see how this could be going wrong.  I'm
guessing, though, that this is a relatively untested path, since people
don't tend to use APM+SMP.

> > .config & lspci attached
> 
> I have but a lowly A21P.  With my .config it APM resumes happily.  With
> yours it refuses to even suspend.  And:
> 
> 
> 
> hdc: DMA disabled
> e100: Intel(R) PRO/100 Network Driver, 3.2.3-k2-NAPI
> e100: Copyright(c) 1999-2004 Intel Corporation

I've been using the eepro100 driver lately, which doesn't seem to have
this problem at all.

	J


      reply	other threads:[~2004-11-19 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19  9:10 2.6.10-rc2-mm2: spinlock problem in arch/i386/kernel/time.c on resume Jeremy Fitzhardinge
2004-11-19 10:53 ` Andrew Morton
2004-11-19 21:14   ` Jeremy Fitzhardinge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100898871.5056.10.camel@localhost \
    --to=jeremy@goop.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).