From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Matthias Hentges <mailinglisten@hentges.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: pci-resume patch from 2.6.7-rc2 breakes S3 resume on some machines
Date: Mon, 22 Nov 2004 15:52:20 +1100 [thread overview]
Message-ID: <1101099140.13598.67.camel@gaston> (raw)
In-Reply-To: <1101098057.4589.2.camel@mhcln03>
On Mon, 2004-11-22 at 05:34 +0100, Matthias Hentges wrote:
> Am Montag, den 22.11.2004, 08:39 +1100 schrieb Benjamin Herrenschmidt:
>
> > That "update only what changed" makes little sense
>
> Sorry, I was merely stating my observations.
>
> > ... can you send me
> > the lspci state of the Intel bridge before you try to resume it ? I
> > suspect our pci_restore_state() should be smarter, that is check if
> > something changed (a BAR), if yes, switch mem/io off, restore the BARs,
> > then switch mem/io back on...
>
> Attached.
Ok, it's clearly visible that your CPU->AGP bridge isn't properly
restored. I can't tell if the "default" resume code is enough tho, but
it's fairly probably that this isn't the only problem, and that the
video chip itself isn't restored neither...
I don't think the default resume code is to blame here, though the CPU
to AGP bridge may need some special restore code restoring more than
just it's config space (very probable even). I suspect there is some
ACPI trickery here that should be happening and isn't but my knowledge
of ACPI isn't that great.
Once the config space is resumed, I suppose doing a soft-boot of the
card with the BIOS would work, but then, that means preventing anything
from actually touching the video card until that happens...
Ben.
next prev parent reply other threads:[~2004-11-22 4:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-18 21:05 pci-resume patch from 2.6.7-rc2 breakes S3 resume on some machines Matthias Hentges
2004-11-19 11:55 ` Pavel Machek
2004-11-19 13:56 ` Matthias Hentges
2004-11-19 23:06 ` Benjamin Herrenschmidt
2004-11-20 2:43 ` Matthew Garrett
2004-11-20 3:36 ` Matthias Hentges
2004-11-20 7:34 ` Benjamin Herrenschmidt
2004-11-20 8:01 ` Matthias Hentges
2004-11-20 22:27 ` Benjamin Herrenschmidt
2004-11-21 8:50 ` Matthias Hentges
2004-11-21 21:39 ` Benjamin Herrenschmidt
2004-11-22 4:34 ` Matthias Hentges
2004-11-22 4:52 ` Benjamin Herrenschmidt [this message]
2004-11-20 7:33 ` Benjamin Herrenschmidt
2004-11-20 22:29 ` Pavel Machek
2004-11-19 11:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101099140.13598.67.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailinglisten@hentges.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).