linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Gortmaker <penguin@muskoka.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c]
Date: Sat, 08 Jan 2005 15:45:51 +0000	[thread overview]
Message-ID: <1105197689.10505.22.camel@localhost.localdomain> (raw)
In-Reply-To: <41DF9AC1.2010609@muskoka.com>

On Sad, 2005-01-08 at 08:33, Paul Gortmaker wrote:
> Is it possible that skb_padto has since got its act together?   Reason I
> ask is that I just dusted off a crusty 386dx40 (doesn't get much older

Could be - kmalloc has probably improved but the skbuffs have got far
more complex

> than that) with a wd8013.  As a basic test, I did ttcp Tx tests with small
> packets and they came out to all intents and purposes, identical.   Kernel 
> was 2.6.10, with stack vs skb_padto, each size test ran 3 times, even tested
> packets bigger than ETH_ZLEN as a (hopefully) invariant.  I've attached the
> edited down results below.

What are you testing ? I don't see the relationship between network
throughput and efficiency on this device.

Drop it on a pentium or late 486 and use the tsc to compare the two code
paths. One is much much more efficienct.


  reply	other threads:[~2005-01-08 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <41DED9FA.7080106@pobox.com>
2005-01-08  8:33 ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c] Paul Gortmaker
2005-01-08 15:45   ` Alan Cox [this message]
2005-01-10  2:41     ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c Paul Gortmaker
2005-01-10 18:28       ` Alan Cox
2005-02-19  5:20         ` Jeff Garzik
2005-02-19 14:06           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105197689.10505.22.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin@muskoka.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).