linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Arjan van de Ven <arjan@infradead.org>
Cc: viro@zenII.uk.linux.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>
Subject: Re: make flock_lock_file_wait static
Date: Sun, 09 Jan 2005 17:44:10 -0500	[thread overview]
Message-ID: <1105310650.11315.19.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20050109194209.GA7588@infradead.org>

su den 09.01.2005 Klokka 19:42 (+0000) skreiv Arjan van de Ven:
> Hi,
> 
> the patch below makes flock_lock_file_wait static, because it is only used
> (once) in fs/locks.c. Making it static allows gcc to generate better code
> (partial or entirely inlining it, gcc 3.4 also optimizes the calling
> convention for static functions which are guaranteed only local to the file)

Veto. That function is also there for those filesystems that need to
mirror their locks in the VFS. I believe the GFS people are already
using it (they implemented all this anyway), and sooner or later, NFS is
going to have to do it too...

Cheers,
  Trond
-- 
Trond Myklebust <trond.myklebust@fys.uio.no>


  reply	other threads:[~2005-01-09 22:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-09 19:42 make flock_lock_file_wait static Arjan van de Ven
2005-01-09 22:44 ` Trond Myklebust [this message]
2005-01-10  8:19   ` Arjan van de Ven
2005-01-10  8:38     ` Arjan van de Ven
2005-01-10 14:23       ` Trond Myklebust
2005-01-11  8:31         ` Arjan van de Ven
2005-01-11 19:16           ` Trond Myklebust
2005-01-11 19:36             ` Arjan van de Ven
2005-01-25 18:58               ` Paul E. McKenney
2005-01-26  3:10                 ` Andrew Morton
2005-01-26  9:01                 ` Arjan van de Ven
2005-01-26 16:07                   ` Paul E. McKenney
2005-01-26 18:59                     ` Arjan van de Ven
2005-01-28 14:14                       ` Paul E. McKenney
2005-01-28 18:50                         ` Christoph Hellwig
2005-01-28 19:01                         ` Arjan van de Ven
2005-01-26  9:43                 ` Christoph Hellwig
2005-01-26  9:51                   ` Al Viro
2005-01-26  9:55                     ` Christoph Hellwig
2005-01-26 10:00                       ` Al Viro
2005-01-15 21:35             ` Adrian Bunk
2005-01-15 22:07               ` Trond Myklebust
2005-01-10  8:35   ` Ken Preslan
2005-01-10  8:44     ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105310650.11315.19.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zenII.uk.linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).