From: Rusty Russell <rusty@rustcorp.com.au>
To: "Godse, Radheka" <radheka.godse@intel.com>
Cc: "Tantilov, Emil S" <emil.s.tantilov@intel.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: issue in the kernel parsing with multiple arguments
Date: Mon, 10 Jan 2005 14:10:22 +1100 [thread overview]
Message-ID: <1105326622.22093.6.camel@localhost.localdomain> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A84708A8E225@orsmsx401.amr.corp.intel.com>
On Fri, 2005-01-07 at 16:31 -0800, Godse, Radheka wrote:
> Rusty,
>
> We observed a problem when loading a kernel module that accepts
> multiple arguments for single parameter. The issue happens when the
> number of the arguments exceeds the limit of the parameter.
Thanks, I've enclosed a fix for the direct problem.
Name: Catch module parameter parsing failures
Status: Tested on 2.6.10-bk12
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Radheka Godse <radheka.godse@intel.com> pointed out that parameter
parsing failures allow a module still to be loaded. Trivial fix.
Index: linux-2.6.10-bk12-Misc/kernel/module.c
===================================================================
--- linux-2.6.10-bk12-Misc.orig/kernel/module.c 2005-01-10 13:11:54.000000000 +1100
+++ linux-2.6.10-bk12-Misc/kernel/module.c 2005-01-10 13:55:15.839488248 +1100
@@ -1706,6 +1706,9 @@
/ sizeof(struct kernel_param),
NULL);
}
+ if (err < 0)
+ goto arch_cleanup;
+
err = mod_sysfs_setup(mod,
(struct kernel_param *)
sechdrs[setupindex].sh_addr,
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
parent reply other threads:[~2005-01-11 1:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <F760B14C9561B941B89469F59BA3A84708A8E225@orsmsx401.amr.corp.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105326622.22093.6.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=emil.s.tantilov@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=radheka.godse@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).