Re: issue in the kernel parsing with multiple arguments

Re: issue in the kernel parsing with multiple arguments

[Rusty Russell]

On Fri, 2005-01-07 at 16:31 -0800, Godse, Radheka wrote:
> Rusty,
> 
> We observed a problem when loading a kernel module that accepts
> multiple arguments for single parameter. The issue happens when the
> number of the arguments exceeds the limit of the parameter.

Thanks, I've enclosed a fix for the direct problem.

Name: Catch module parameter parsing failures
Status: Tested on 2.6.10-bk12
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Radheka Godse <radheka.godse@intel.com> pointed out that parameter
parsing failures allow a module still to be loaded.  Trivial fix.

Index: linux-2.6.10-bk12-Misc/kernel/module.c
===================================================================
--- linux-2.6.10-bk12-Misc.orig/kernel/module.c	2005-01-10 13:11:54.000000000 +1100
+++ linux-2.6.10-bk12-Misc/kernel/module.c	2005-01-10 13:55:15.839488248 +1100
@@ -1706,6 +1706,9 @@
 				 / sizeof(struct kernel_param),
 				 NULL);
 	}
+	if (err < 0)
+		goto arch_cleanup;
+
 	err = mod_sysfs_setup(mod, 
 			      (struct kernel_param *)
 			      sechdrs[setupindex].sh_addr,

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman