From: Thomas Gleixner <tglx@linutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.10-mm2 Resend] Make use of preempt_schedule_irq [3/3] (ARM)
Date: Wed, 12 Jan 2005 13:08:15 +0100 [thread overview]
Message-ID: <1105531695.17853.232.camel@tglx.tec.linutronix.de> (raw)
In-Reply-To: <20050112124910.1.patchmail@tglx>
[-- Attachment #1: Type: text/plain, Size: 106 bytes --]
Make use of the new preempt_schedule_irq function.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
[-- Attachment #2: entry-armv.S.diff --]
[-- Type: text/x-patch, Size: 800 bytes --]
Index: 2.6.10-mm2-lockinit/arch/arm/kernel/entry-armv.S
===================================================================
--- 2.6.10-mm2-lockinit/arch/arm/kernel/entry-armv.S (revision 148)
+++ 2.6.10-mm2-lockinit/arch/arm/kernel/entry-armv.S (working copy)
@@ -136,11 +136,9 @@
ldr r1, [r6, #8] @ local_bh_count
adds r0, r0, r1
movne pc, lr
- mov r7, #PREEMPT_ACTIVE
- str r7, [r8, #TI_PREEMPT] @ set PREEMPT_ACTIVE
-1: enable_irq r2 @ enable IRQs
- bl schedule
- disable_irq r0 @ disable IRQs
+ mov r7, #0 @ preempt_schedule_irq
+ str r7, [r8, #TI_PREEMPT] @ expects preempt_count == 0
+1: bl preempt_schedule_irq @ irq en/disable is done inside
ldr r0, [r8, #TI_FLAGS] @ get new tasks TI_FLAGS
tst r0, #_TIF_NEED_RESCHED
beq preempt_return @ go again
next prev parent reply other threads:[~2005-01-12 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 11:49 [PATCH 2.6.10-mm2 Resend] Fix preemption race [1/3] (Core/i386) tglx
2005-01-12 11:57 ` [PATCH 2.6.10-mm2 Resend] Make use of preempt_schedule_irq [2/3] (PPC) Thomas Gleixner
2005-01-12 12:08 ` Thomas Gleixner [this message]
2005-01-13 0:05 ` [PATCH 2.6.10-mm2 Resend] Fix preemption race [1/3] (Core/i386) Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105531695.17853.232.camel@tglx.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).