From: Daniel McNeil <daniel@osdl.org>
To: Sami Farin <7atbggg02@sneakemail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH - 2.6.10] generic_file_buffered_write handle partial DIO writes with multiple iovecs
Date: Wed, 19 Jan 2005 13:06:27 -0800 [thread overview]
Message-ID: <1106168787.3041.60.camel@ibm-c.pdx.osdl.net> (raw)
In-Reply-To: <20050119172812.GR6725@m.safari.iki.fi>
On Wed, 2005-01-19 at 09:28, Sami Farin wrote:
> On Wed, Jan 19, 2005 at 08:55:40AM -0800, Daniel McNeil wrote:
> > On Tue, 2005-01-18 at 18:31, Sami Farin wrote:
> ...
> > > I have Linux 2.6.10-ac9 + bio clone memory corruption -patch,
> > > and dio_bug does not give errors (without your patch).
> >
> > I should have mentioned that my testing was on ext3 with 4k
> > block size. The bio clone patch might affect this by merging
> > the i/o into a single iovec. Here's an updated test program
> > that uses 2 different buffers allocated separately that might
> > prevent the merging. See if this works on your system.
>
> I have reiserfs... and this version does not give errors, either.
Reisefs must handle allocations differently. The bug only
shows up if there is an unallocated hole and a O_DIRECT write with
multiple iovecs writes partially into the allocated space
and completes at least 1 iovec worth of data and then finishes
the i/o using buffer i/o to allocate space for the hole and write
the remaining data.
Daniel
prev parent reply other threads:[~2005-01-19 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 1:22 [PATCH - 2.6.10] generic_file_buffered_write handle partial DIO writes with multiple iovecs Daniel McNeil
2005-01-19 2:31 ` Sami Farin
2005-01-19 16:55 ` Daniel McNeil
2005-01-19 17:28 ` Sami Farin
2005-01-19 21:06 ` Daniel McNeil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106168787.3041.60.camel@ibm-c.pdx.osdl.net \
--to=daniel@osdl.org \
--cc=7atbggg02@sneakemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).