From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: Radeon framebuffer weirdness in -mm2
Date: Mon, 24 Jan 2005 15:00:37 +1100 [thread overview]
Message-ID: <1106539238.5210.16.camel@gaston> (raw)
In-Reply-To: <20050121060928.GI12076@waste.org>
On Thu, 2005-01-20 at 22:09 -0800, Matt Mackall wrote:
>
> It's something in this batch. Which is good, as I'd be a bit
> disappointed if the "vt leakage" were somehow attributable to the fb
> layer. More bisection after dinner.
Regarding the radeonfb reboot problem, can you try this patch on
top of -mm2 ?
--- linux-work.orig/drivers/video/aty/radeon_base.c 2005-01-24 12:19:09.000000000 +1100
+++ linux-work/drivers/video/aty/radeon_base.c 2005-01-24 14:59:14.000000000 +1100
@@ -2435,13 +2435,16 @@
radeonfb_pm_exit(rinfo);
+#if 0
/* restore original state
*
- * Doesn't quite work yet, possibly because of the PPC hacking
- * I do on startup, disable for now. --BenH
+ * Doesn't quite work yet, I suspect if we come from a legacy
+ * VGA mode (or worse, text mode), we need to do some VGA black
+ * magic here that I know nothing about. --BenH
*/
radeon_write_mode (rinfo, &rinfo->init_state, 1);
-
+ #endif
+
del_timer_sync(&rinfo->lvds_timer);
#ifdef CONFIG_MTRR
next prev parent reply other threads:[~2005-01-24 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 23:21 Radeon framebuffer weirdness in -mm2 Matt Mackall
2005-01-20 23:39 ` Andrew Morton
2005-01-20 23:48 ` Matt Mackall
2005-01-21 0:01 ` Andrew Morton
2005-01-21 3:57 ` Matt Mackall
2005-01-21 4:05 ` Andrew Morton
2005-01-21 4:07 ` Andrew Morton
2005-01-21 6:09 ` Matt Mackall
2005-01-21 12:33 ` Roman Zippel
2005-01-21 16:36 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-01-22 0:52 ` Matt Mackall
2005-01-24 4:00 ` Benjamin Herrenschmidt [this message]
2005-01-21 16:36 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-01-21 0:03 ` Benjamin Herrenschmidt
2005-01-21 0:24 ` [Linux-fbdev-devel] " James Simmons
2005-01-21 0:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106539238.5210.16.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).