From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932230AbdJUSz2 (ORCPT ); Sat, 21 Oct 2017 14:55:28 -0400 Received: from mout.web.de ([212.227.15.3]:52681 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbdJUSz0 (ORCPT ); Sat, 21 Oct 2017 14:55:26 -0400 To: linux-block@vger.kernel.org, nbd@other.debian.org, Josef Bacik Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] nbd: Use common error handling code in nbd_genl_connect() Message-ID: <110a7553-d57c-6a77-a9f7-fdee43a60195@users.sourceforge.net> Date: Sat, 21 Oct 2017 20:55:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:M7bLJY8A54sL5W+XQu0mIdgEUq0VWwV/iuReTH8LpRVShacf9IN glMvyH7+CP4Q2jSBxZLXDoRQ5slzs9/8HZK5v01a6vJizJYQQ2/w8qAa3ZXxWGVVRCyVCzl jj/m5D3FxMzyQ37ngJVJjXPvehQzpSV97IPOKDzO4SIGi6+YPyASzbBLNfop0TfbAHMb8qJ NuhDBJ16MT4J35IEw3HWw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xuYXlF3aczw=:eT/VeGvCE86t3tcu4fyR0b yRb9BEyJjhj7tITgOa3/uXx9aqPYg1PH4HemTiZH5gI4jxK97C0ursGPhWvsirND2Xrsa8Zx5 LnuKeEEniFifnbG7fZHZU/zEIzzkpT2gln3Scxa2aiiJQi0HSLjJtU5RJJ2F63rBzWxxzP68u Bmk96yT2pglbvG1F0qCLDyG0Y2SCAN91zBI54yNrZw56JremRIOcluVI8KRJmpvKsTz7Pt3Jf FeP/AIm8NLH8gcvHSEftwg0f2pv77RX7FBXBWEUhpAn5MLDDe+2Ylu/YRicRtqPn5vyHA4z8g I+62PIYYJl7nCJwCjkRRjhsGl1eAS82MDhLo36TISa9lbhzqzX+l/GBfMYDZnSOuvF5WUhnGx XiJmdIYtOT4+ZnpJwmwhLu9RET6LsYy3y28slRI4Enz6QMBP91n8n8F4nj9Sn/VwS5W+2MW7p DFVlUtjo1CoAhdV6mNe+yOBKgJYT2wf9VVeo7VTaLf8sZPvxtGXzxfs3ThaWhKvDEMP8KP1X/ ha0a+scYfRIfatHqJz0mD/npqzk6vh2mqtXrosiu4Ta4jPgOCFxaoKtjsA4O/6h9m/3znReZn U46LeLdqJsqeM/YqEHbfx8d7l98zL1+0JkAmtnQGeeq3062SPdBFc8eLj/JS6viscOIbHCAhS AzpI00vfIMl5DG4FxvKvUkrgJPNAv/SxdZ3RlC3NDlbYvo8e8FAFIw4PquuJX6IdRR6gJFVLg ng2WYqArWdZQuMWoxGPkZlRyb90PsPde3mZVni4HQ6FJiJUxNzpQxFl8XrvBJKtWVWlbXFXsJ 4JyfxeNwvd7JYApe4ULmVrBVAbjxu+8yYa0PTa+YtIZaEKTUX4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 21 Oct 2017 20:50:37 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/block/nbd.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 883dfebd3014..05bd1fc70ee3 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1585,22 +1585,18 @@ static int nbd_genl_connect(struct sk_buff *skb, struct genl_info *info) if (ret == 0) { int new_index; new_index = nbd_dev_add(-1); - if (new_index < 0) { - mutex_unlock(&nbd_index_mutex); - printk(KERN_ERR "nbd: failed to add new device\n"); - return ret; - } + if (new_index < 0) + goto report_failure; + nbd = idr_find(&nbd_index_idr, new_index); } } else { nbd = idr_find(&nbd_index_idr, index); if (!nbd) { ret = nbd_dev_add(index); - if (ret < 0) { - mutex_unlock(&nbd_index_mutex); - printk(KERN_ERR "nbd: failed to add new device\n"); - return ret; - } + if (ret < 0) + goto report_failure; + nbd = idr_find(&nbd_index_idr, index); } } @@ -1716,6 +1712,11 @@ static int nbd_genl_connect(struct sk_buff *skb, struct genl_info *info) if (put_dev) nbd_put(nbd); return ret; + +report_failure: + mutex_unlock(&nbd_index_mutex); + pr_err("nbd: failed to add new device\n"); + return ret; } static int nbd_genl_disconnect(struct sk_buff *skb, struct genl_info *info) -- 2.14.2