From: Arnd Bergmann <arnd@arndb.de>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"
Date: Wed, 01 Jun 2016 23:09:47 +0200 [thread overview]
Message-ID: <11128570.JeBAgI5zQr@wuerfel> (raw)
In-Reply-To: <m3inxt17zo.fsf@t19.piap.pl>
On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote:
> Bjorn Helgaas <bhelgaas@google.com> writes:
>
> > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1.
> >
> > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna
> > GW-2388) because the MRRS setting is never written to the hardware.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Krzysztof Hałasa <khalasa@piap.pl>
> > ---
> > arch/arm/mach-cns3xxx/pcie.c | 71 ++++++++++++++++++++++++------------------
> > 1 file changed, 41 insertions(+), 30 deletions(-)
>
> This, applied to v4.7-rc1, fixes the problem on my Laguna boards.
>
> Tested-by: Krzysztof Hałasa <khalasa@piap.pl>
>
> And as well
>
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
Thank!
Obviously, I'd rather not bring back the gcc warning or the potential
stack overflow (however unlikely).
What exactly is the problem we are seeing, and is there a way to fix
it on top of my patch? Are we perhaps just missing a call to
pcie_bus_configure_settings()?
Note that cns3xxx is in a bit of an odd state, as only half of the
platform code is even present in the kernel, and there is no effort
to change that. As far as I know, the board that this was tested on
is not present in the mainline kernel, and the board we support
is a development system that few people even own at this point.
Arnd
next prev parent reply other threads:[~2016-06-01 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:58 [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow" Bjorn Helgaas
2016-05-31 22:02 ` Bjorn Helgaas
2016-06-01 11:08 ` Krzysztof Hałasa
2016-06-01 21:09 ` Arnd Bergmann [this message]
2016-06-09 5:42 ` Krzysztof Hałasa
2016-06-09 14:42 ` Arnd Bergmann
2016-06-10 10:10 ` Krzysztof Hałasa
2016-06-10 21:57 ` Arnd Bergmann
2016-06-16 4:39 ` Krzysztof Hałasa
2016-06-09 17:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11128570.JeBAgI5zQr@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).