From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751463AbcFAVJO (ORCPT ); Wed, 1 Jun 2016 17:09:14 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49734 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbcFAVJN convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 17:09:13 -0400 From: Arnd Bergmann To: Krzysztof =?utf-8?B?SGHFgmFzYQ==?= Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow" Date: Wed, 01 Jun 2016 23:09:47 +0200 Message-ID: <11128570.JeBAgI5zQr@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160531215802.30590.97398.stgit@bhelgaas-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:i0V2EIbh3DgLfCi+OxTzLF0P6wf/ZhI6JREIriToj87Jl3+H3FQ 4HQKrzp3EG1XQFchrwo48V14zFi975xmaKuqgv/vNgsLj810khWZXWhv9bPqJWKkfY1+G+f MEjPX6VnnFrZMy3XVJzGmMfqJT0Ki3yrdedYpPLjmvzhSnNrtNgBkEWLLTNe5DY4K8ugVTM 93NDXmPhP79rkNuMjslxQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+7mIek9zLEs=:8lQhB7QwjOfjHQJaEfn0rO zfv7DPdzJgpsVVJmTNTBdNarj+Oxr0CI/cnimbYO1ucto+BkUZJK4XjHfufls1RG8DXy9Oli8 tkB3tBBfTS3ZfvWvBKmNSvqbJgLI8BPWNlMgH2PcbnTtUA0e5u2uwUK9WczNyTaMKslRCPAWf wQ0aixjpbIY+ufK8fBkOXxROFlaSmzkBOXpW0IU0qrKHaM2DQE3dJGQx0tHPJ/bz17hH2rPoT W6c0zfige00rye0dDFyxyerWK6+B4nRV9+9vKUabn2bTef4MPcrnuvs6N19rVg0VtBwUdp3w2 mo/LdjcmXvTPUiFPNEj37sCTRGg2kbKFrg6AUECc8hFO/45AmyNtU+KeE5YRQULiV22bH1b7T UwdpT95jDNHeaEebzKrZ3xU2blqM2Es/fDxfEym3jSLYJZE3b/S/GURpt6Kqv2toOU57QeuTx 2QeiU6A4F5dLQDGP4ZmoRFyPy8N/ROCIMJC4dRniiN8lAvTY1yLfsWwlG//h9Uxxvum3mMpJp euGIa4m23wfBr/ebWa7D5UI75jpDws97vKFdVNwLo1RF0x3iovZQyQdQLPZ5n0oWpdENzuwZY eEo534/nXkigVOL7QBK4XuBnORsdzedecvF1AaegRPmixPQSm+/Lo0FM7o1yvRlQqu81YKAYV 1tdf9rldxtV8BgWCF4oTO2+FJc9dmXsYLVg2LnNqU/H0XwyuNBvC82BytWVz7pmAxD2LBbKV5 l+puFpQSqFliZPl2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote: > Bjorn Helgaas writes: > > > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > > GW-2388) because the MRRS setting is never written to the hardware. > > > > Signed-off-by: Bjorn Helgaas > > CC: Arnd Bergmann > > CC: Krzysztof Hałasa > > --- > > arch/arm/mach-cns3xxx/pcie.c | 71 ++++++++++++++++++++++++------------------ > > 1 file changed, 41 insertions(+), 30 deletions(-) > > This, applied to v4.7-rc1, fixes the problem on my Laguna boards. > > Tested-by: Krzysztof Hałasa > > And as well > > Acked-by: Krzysztof Hałasa Thank! Obviously, I'd rather not bring back the gcc warning or the potential stack overflow (however unlikely). What exactly is the problem we are seeing, and is there a way to fix it on top of my patch? Are we perhaps just missing a call to pcie_bus_configure_settings()? Note that cns3xxx is in a bit of an odd state, as only half of the platform code is even present in the kernel, and there is no effort to change that. As far as I know, the board that this was tested on is not present in the mainline kernel, and the board we support is a development system that few people even own at this point. Arnd