From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261540AbVDORyq (ORCPT ); Fri, 15 Apr 2005 13:54:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261869AbVDORyq (ORCPT ); Fri, 15 Apr 2005 13:54:46 -0400 Received: from [81.2.110.250] ([81.2.110.250]:46535 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S261540AbVDORyp (ORCPT ); Fri, 15 Apr 2005 13:54:45 -0400 Subject: Re: [2.6 patch] drivers/net/wan/: possible cleanups From: Alan Cox To: Adrian Bunk Cc: netdev@oss.sgi.com, Linux Kernel Mailing List In-Reply-To: <20050414232028.GD20400@stusta.de> References: <20050327143418.GE4285@stusta.de> <1111941516.14877.325.camel@localhost.localdomain> <20050414232028.GD20400@stusta.de> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1113587392.11155.33.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Fri, 15 Apr 2005 18:49:56 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Gwe, 2005-04-15 at 00:20, Adrian Bunk wrote: > On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote: > > On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote: > > > - syncppp.c: sppp_input > > > - syncppp.c: sppp_change_mtu > > > - z85230.c: z8530_dma_sync > > > - z85230.c: z8530_txdma_sync > > > > Please leave the z85230 ones at least. They are an intentional part of > > the external API for writing other 85230 card drivers. > > If they are part of an API, why aren't the prototypes for them in any > header file? They were once. I guess that got "tided" at some point, possibly long ago even before submission. z8530_dma_sync and txdma_sync set up the device in DMA mode, or in DMA one direction only mode.