From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965191AbbLOLz5 (ORCPT ); Tue, 15 Dec 2015 06:55:57 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:62936 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964922AbbLOLzz (ORCPT ); Tue, 15 Dec 2015 06:55:55 -0500 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rogerq@ti.com, nsekhar@ti.com, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, tony@atomide.com, t-kristo@ti.com Subject: Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg Date: Tue, 15 Dec 2015 12:55:37 +0100 Message-ID: <11176831.mhgJlIuj0S@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <566FF621.2040307@ti.com> References: <1450170968-11282-1-git-send-email-kishon@ti.com> <725110094.6UkMkcy8u7@wuerfel> <566FF621.2040307@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:f91qjLHjdf9uxndlrRjmTiANiV8xeGm7hhMgvFL9+cWkylxHKmY +4Be7BwRQZqSUW1Twzgh5k2IxgsTAHLaaXxT4oXWufufgV43RNR62gfm+imcXzpajfKObko DWcsCERo1XeT7IPergcNk3P1aUNIYmME/N75/R5M2N+OvOxZhou2QON4ZgRK1wtQgFJ0rjy L+/E11ratn+L4O9aAGFHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3ARXNDZDGPc=:dKBPUa9YTaP/Mdwtic4ssK pX38Ze+nosaZeYBefpycOK0EMr6Q4A3b+VlrzGZOhNiz7iDd2r97ZV8qY4e5qiUzZUD0ywd6R MHYdPOz0PZcOY3MrLMYkuCQ8ABvrB3umwvNNIE1LVVSOvznh5uAwWcAmqCeKdB3gHt8FSR9DK t4F5oHENBmisolHQwk5sLvl4hjDxP/KYFxZdzR4xzQsQMb2MRuvk4mq+Kpnbq7hOhEcx0Mrd6 3EOynp2Lzoba7WX910P5AquwUYfQxWbOCbRiJ3luF5OY+u+wJS4pc4xl60ffcR9L7goB4tfQ4 CM9ete9fY3lu+KUQjv2E4ZHu6pFzHA7AZyJTfVVKwjyBfSzRJqni18+el1Hex3xL5327GqCZm dpbVaENth6go/D3kfPtLS/NAsOdG46HkuDY/dwzAvGQYE+SmedmA/4U8xkYStIBz0USjX1Xfv yAjUkFd/s068thJGBUlk8WkLwGK+nO0q+X2LPUcUTjjFbDo8izaKVXpFEtafqw38BMTw07OZG daGD3hqLWxmGkt2JFi6PQWP1o6Lhh96vG44JzlxH0jxs9Ao0YeoqIpXpDEHr7sNg8hHWD88uC 0TwUjFu4ev8Zfcukwug7x4DpAH7K8uVNXgu+jOAXWlWyQTEbGe52V0E2YR4NY7xOH83gF3LMh 6QGlMcD6NKojBM2JCo0QKcAjIEzFHfcJzMyWeY1v/5qoRKogvU9stypSszTXoWZtj8CbmWB/t Zue1dhXo+AWmSgJI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 15 December 2015 16:44:41 Kishon Vijay Abraham I wrote: > Hi Arnd, > > On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote: > > On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: > >> This series is basically to deprecate using phy-omap-control and use > >> syscon APIs to program the control module registers. > >> > >> Changes from v2: > >> No changes. > >> > >> Changes from v1: > >> *) cleanup ti_pipe3_probe in multiple steps > >> *) other minor cleanups > >> > >> Changes from [1] in PHY patches include > >> *) cleanup ti_pipe3_probe > >> *) have mask, power_on and power_off values in usb_phy_data for > >> omap-usb2 phy > >> > >> The patches have been pushed to > >> git://git.ti.com/linux-phy/linux-phy.git syscon > >> > >> [1] -> https://lkml.org/lkml/2015/6/23/189 > >> > >> All the testing was done both before applying the dt patches and after > >> applying the dt patches (dt patches will be posted shortly). > >> > > > > Can you explain here what the conversion is good for? Why do you > > prefer the syscon mapping over a high-level driver in this case? > > phy-omap-control driver was added when there was no proper > infrastructure for doing control module initializations. The > phy-omap-control driver is not an 'actual' PHY driver and it > was just a hack to do PHY related control module initializations. > phy-omap-control is also getting unmanageable with the number of > platforms each having number of modules (like USB, SATA, PCIe), > using the same driver for control module initializations. > > Now with SYSCON framework being added to the kernel, phy-omap-control > shouldn't be needed and it also provides a uniform API across all the > modules to program the control module. Ok, so the "phy-control" devices were really just a few registers of a system controller device that does a lot of other things as well, right? Can you put your description above into the cover-letter for the series, and the merge commit? Arnd