From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Hemp <c.hemp@phytec.de>
Subject: Re: [PATCH v2 4/5] media: mt9p031: Make pixel clock polarity configurable by DT
Date: Mon, 5 Oct 2020 10:52:01 +0200 [thread overview]
Message-ID: <1121fe39-2965-0782-85cc-2dcb9996b978@phytec.de> (raw)
In-Reply-To: <20201001161111.GQ26842@paasikivi.fi.intel.com>
Hi Sakari,
On 01.10.20 18:11, Sakari Ailus wrote:
> On Thu, Oct 01, 2020 at 07:10:31PM +0300, Sakari Ailus wrote:
>>> @@ -1079,6 +1094,9 @@ mt9p031_get_pdata(struct i2c_client *client)
>>> of_property_read_u32(np, "input-clock-frequency", &pdata->ext_freq);
>>> of_property_read_u32(np, "pixel-clock-frequency", &pdata->target_freq);
>>>
>>> + pdata->pixclk_pol = !!(endpoint.bus.parallel.flags &
>>> + V4L2_MBUS_PCLK_SAMPLE_RISING);
>>
>> Could you document this in DT bindings? And the default, too.
>
> Please make it a separate patch.
Sure, I'll send a separate patch for the DT bindings.
Regards,
Stefan
>
next prev parent reply other threads:[~2020-10-05 8:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 10:51 [PATCH v2 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats Stefan Riedmueller
2020-09-30 10:51 ` [PATCH v2 2/5] media: mt9p031: Read back the real clock rate Stefan Riedmueller
2020-10-01 23:56 ` Laurent Pinchart
2020-09-30 10:51 ` [PATCH v2 3/5] media: mt9p031: Implement [gs]_register debug calls Stefan Riedmueller
2020-09-30 11:38 ` Laurent Pinchart
2020-10-01 8:56 ` Stefan Riedmüller
2020-10-02 0:06 ` Laurent Pinchart
2020-10-05 9:33 ` Stefan Riedmüller
2020-09-30 10:51 ` [PATCH v2 4/5] media: mt9p031: Make pixel clock polarity configurable by DT Stefan Riedmueller
2020-10-01 16:10 ` Sakari Ailus
2020-10-01 16:11 ` Sakari Ailus
2020-10-05 8:52 ` Stefan Riedmüller [this message]
2020-09-30 10:51 ` [PATCH v2 5/5] media: mt9p031: Fix corrupted frame after restarting stream Stefan Riedmueller
2020-10-02 0:05 ` Laurent Pinchart
2020-10-05 9:28 ` Stefan Riedmüller
2020-10-05 13:08 ` Laurent Pinchart
2020-10-14 7:14 ` Stefan Riedmüller
2020-09-30 11:42 ` [PATCH v2 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats Laurent Pinchart
2020-10-01 9:07 ` Stefan Riedmüller
2020-10-01 23:53 ` Laurent Pinchart
2020-10-05 9:31 ` Stefan Riedmüller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121fe39-2965-0782-85cc-2dcb9996b978@phytec.de \
--to=s.riedmueller@phytec.de \
--cc=c.hemp@phytec.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).