From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Archit Taneja <architt@codeaurora.org>,
David Airlie <airlied@linux.ie>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lars-Peter Clausen <lars@metafoo.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC][PATCH 3/3] drm/bridge: adv7511: Enable HPD interrupts to support hotplug and improve monitor detection
Date: Tue, 22 Nov 2016 10:29:30 +0200 [thread overview]
Message-ID: <11227748.KeIGuHD5tB@avalon> (raw)
In-Reply-To: <1479775052-28194-4-git-send-email-john.stultz@linaro.org>
Hi John,
Thank you for the patch.
On Monday 21 Nov 2016 16:37:32 John Stultz wrote:
> From: Archit Taneja <architt@codeaurora.org>
>
> On some adv7511 implementations, we can get some spurious
> disconnect signals which can cause monitor probing to fail.
>
> This patch enables HPD (hot plug detect) interrupt support
> which allows the monitor to be properly re-initialized when
> the spurious disconnect signal goes away.
>
> This also enables proper hotplug support.
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Originally-by: Archit Taneja <architt@codeaurora.org>
> [jstultz: Added proper commit message]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
This looks good to me.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 2114a4c..889cf36
> 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -338,7 +338,7 @@ static void __adv7511_power_on(struct adv7511 *adv7511)
> * Still, let's be safe and stick to the documentation.
> */
> regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0),
> - ADV7511_INT0_EDID_READY);
> + ADV7511_INT0_EDID_READY | ADV7511_INT0_HPD);
> regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(1),
> ADV7511_INT1_DDC_ERROR);
> }
> @@ -825,6 +825,10 @@ static int adv7511_bridge_attach(struct drm_bridge
> *bridge) if (adv->type == ADV7533)
> ret = adv7533_attach_dsi(adv);
>
> + if (adv->i2c_main->irq)
> + regmap_write(adv->regmap, ADV7511_REG_INT_ENABLE(0),
> + ADV7511_INT0_HPD);
> +
> return ret;
> }
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-11-22 8:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 0:37 [RFC][PATCH 0/3] adv7511 EDID probing improvements John Stultz
2016-11-22 0:37 ` [RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally John Stultz
2016-11-22 8:14 ` Laurent Pinchart
2016-11-22 8:16 ` John Stultz
2016-11-22 8:27 ` Laurent Pinchart
2016-11-22 17:25 ` John Stultz
2016-11-22 17:38 ` Laurent Pinchart
2016-11-22 17:44 ` John Stultz
2016-11-22 19:46 ` John Stultz
2016-11-23 3:50 ` Archit Taneja
2016-11-28 18:44 ` John Stultz
2016-11-22 0:37 ` [RFC][PATCH 2/3] drm/bridge: adv7511: Add 200ms delay on power-on John Stultz
2016-11-22 8:25 ` Laurent Pinchart
2016-11-22 17:38 ` John Stultz
2016-11-22 18:07 ` John Stultz
2016-11-22 18:23 ` Laurent Pinchart
2016-11-22 18:53 ` John Stultz
2016-11-23 7:55 ` Daniel Vetter
2016-11-25 0:23 ` Laurent Pinchart
2016-11-25 6:33 ` Daniel Vetter
2016-11-22 0:37 ` [RFC][PATCH 3/3] drm/bridge: adv7511: Enable HPD interrupts to support hotplug and improve monitor detection John Stultz
2016-11-22 8:29 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11227748.KeIGuHD5tB@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).