From: Thomas Gleixner <tglx@linutronix.de>
To: dwalker@mvista.com
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK
Date: Wed, 28 Sep 2005 00:28:32 +0200 [thread overview]
Message-ID: <1127860112.15115.213.camel@tglx.tec.linutronix.de> (raw)
In-Reply-To: <1127845928.4004.26.camel@dhcp153.mvista.com>
On Tue, 2005-09-27 at 11:32 -0700, Daniel Walker wrote:
> Convert unwritten_done_lock xfs lock to the new syntax.
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
> +++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
> @@ -192,7 +192,7 @@ linvfs_unwritten_done(
> int uptodate)
> {
> xfs_ioend_t *ioend = bh->b_private;
> - static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
> + static DECLARE_SPINLOCK(unwritten_done_lock);
> unsigned long flags;
Did you actually compile this ?
tglx
--- linux-2.6.13.orig/fs/xfs/linux-2.6/xfs_aops.c
+++ linux-2.6.13/fs/xfs/linux-2.6/xfs_aops.c
@@ -192,7 +192,7 @@ linvfs_unwritten_done(
int uptodate)
{
xfs_ioend_t *ioend = bh->b_private;
- static spinlock_t unwritten_done_lock = SPIN_LOCK_UNLOCKED;
+ static DEFINE_SPINLOCK(unwritten_done_lock);
unsigned long flags;
ASSERT(buffer_unwritten(bh));
next prev parent reply other threads:[~2005-09-27 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 18:32 [PATCH] RT: unwritten_done_lock to DEFINE_SPINLOCK Daniel Walker
2005-09-27 22:28 ` Thomas Gleixner [this message]
2005-09-28 9:34 ` Ingo Molnar
2005-09-28 15:04 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127860112.15115.213.camel@tglx.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).