From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbbF3U25 (ORCPT ); Tue, 30 Jun 2015 16:28:57 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:50161 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbbF3U2u (ORCPT ); Tue, 30 Jun 2015 16:28:50 -0400 From: Arnd Bergmann To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, gregkh@linuxfoundation.org, wenyou.yang@atmel.com, ludovic.desroches@atmel.com, leilei.zhao@atmel.com, josh.wu@atmel.com, alexandre.belloni@free-electrons.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, galak@codeaurora.org, ijc+devicetree@hellion.org.uk, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style Date: Tue, 30 Jun 2015 22:28:42 +0200 Message-ID: <11308515.NsBzDiA1lH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen@atmel.com> References: <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen@atmel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:sUgGEDzNvrJlyQ6eM/xuuGU00ACiKZQBbQEQ6J7irLQ1E/5zBP/ Et7PtbJLiyu/HIUev32DdKqOA3wxZWvJiZ0JE7HzNHnhYiH5Z2zpNSntUehKvzc0P2b+Wps ZFeNatfs8x5WXhj78hcda0yeuvLzuDz3dzjwoZShNtsdK06IiT/3wxHVYbmgGWbTd5fn67I LNkfdOvv0RiVx/mlCUMJQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mguxZjhtw24=:ix2RM++rGlBfjtpPj7uTYA c3rfG3fT/d1M+TbJfhQQqsnXwlK3nopp5rurR3RIANqO16IsiGUiOp6YyZnVSxn5w3cRCxLRM c9C4GyqVkNfWBGyfI43j5IEVtD8hZr4ObaTvbG7sGoX6O3Vp6rAJMi5riRp+bI2mil1Y9uSrk SykLuDK1ek4kFGw2mn0XptMrQQ9ql3F3RiUG/io7JVIXA+kCJFZiEIHX9X9rdaNzPGKmHk/FT 1AAMQiqvrAc2pfJteUx71sCRUm+9cRHrfxjBhQAaLMrcpOXjHZ4moDMmbvzftzJ7SQznHYzcz BEv+osD7sudJXhP8++8tH4BMHtDNQ2GwCwL51i+O36+8YzdzSADWtRS8Qgtxo+ugcmQAVQAjh hYLzcTVeduwoD45vG+5kpsOg/D4doFf+IiSLxZ1RPn9oeboI9H0YIoK/Q0ed98gObmlp/nZrE 0mDwbM0hd373R8VHYd6loNP3fbdBjpKQ0IjYtrngq4QW8rNHkcGLJm2kMo1Fl/p0YavBrgIUa xgjzZX4hx6+CidgRquDXtjCpkCS5jiOwCclbP83BQnhgfI1JO2Bbs/cI2ML39m2Q7rVwWXR8A HVF77iB/gj1s4TLJdqxAIpbzsXWcW0kWMLwkxzGt3w4VoCvfZDgoSscdjoqBdmqzaphVYy+tp V+DN1aK2VhOOwYqyHqW27Y8hlyc8iHFRU7Tvh8XXCrxDb1Q== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote: > +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR) > +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR) > +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR) > +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER) > How about removing these macros entirely? I'm not aware of other drivers doing it like this, and it does not seem to add any value? At the same time, you could use readl_relaxed() to make the driver endian-safe. Arnd